-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Update SkiaSharp and HarfBuzzSharp version to support LA64 and RV64 #18571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
You can test this PR using the following package version. |
|
@cla-avalonia agree |
@cla-avalonia agree |
Can run successfully. |
No issues with preview versions for the skiasharp 3.0. |
Accidentally pressed wrong button...reopening |
You can test this PR using the following package version. |
😂 |
You can test this PR using the following package version. |
We might need this PR to be backported to 11.x since we might need to incorporate mono/SkiaSharp#3098 (also see: mono/SkiaSharp#3025) due to the 16KB page limit. Sims won't launch the apps built without it in Android API 15. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
@maxkatz6 would you reconsider? it is going from 118 preview to 119 preview. their pace of updating stuff is terribly slow. it took them 4 months to go from one preview to the next so you can see why their "preview" claim doesn't mean much to the rest of us (including Avalonia using 118 preview). |
You can test this PR using the following package version. |
The version targeted by Avalonia is the minimum supported one, you can use newer versions in your projects by adding a PackageReference. |
it doesn't explain why bumping preview-old to preview-new is a problem? if anything, new version should be better |
@kasperk81 Also, I am not so much considered about SkiaSharp version change in this PR (since it doesn't affect stable builds), but more about HarfBuzz using preview in stable builds. Waiting until HarfBuzzSharp 8.1.1 stable release before merging this PR. |
What does the pull request do?
Update SkiaSharp and HarfBuzzSharp version to support LoongArch64 ABI2.0 and RISC-V 64, which has native library in nuget.org.
Also, it fixes the build to support Linux with old Glibc.
https://www.nuget.org/packages/SkiaSharp.NativeAssets.Linux/3.119.0-preview.1.2
https://www.nuget.org/packages/HarfBuzzSharp.NativeAssets.Linux/8.3.1.1-preview.1.2
Add riscv64 build support
Add LoongArch64 build support
Extend clang-cross to support alpine
Increase Linux support
What is the current behavior?
Incorrect behavior:Wrong version of SkiaSharp and HarfBuzzSharp that Can't be support in LoongArch64 ABI2.0, RISC-V 64, and old X64 and AArch64 Linux distribution with old Glibc.
What is the updated/expected behavior with this PR?
Use the Watt Toolkit project to test the PR.
https://github.com/4Darmygeometry/SteamTools
How was the solution implemented (if it's not obvious)?
Update the SkiaSharp and HarfBuzzSharp version.
Checklist
Breaking changes
N/A
Obsoletions / Deprecations
@grokys
Fixed issues
Fixes [FEATURE] riscv64 flavor of libSkiaSharp and libHarfBuzzSharp
Fixes [FEATURE] LoongArch64 flavor of libSkiaSharp and libHarfBuzzSharp