-
Notifications
You must be signed in to change notification settings - Fork 570
Add riscv64 build support #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
12d9b7e
to
3172aca
Compare
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
While we wait for the build to run again, are you able to confirm that the artifacts work in the first run? https://dev.azure.com/xamarin/public/_build/results?buildId=137319&view=results |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR up and iterating on it. So far CI has been green all the way.
This is looking done, except for 2 small issues:
- the other 2 targets files also need the risc items
- there are double files in the nuget (not because of this PR) and if you are able to just fix the wildcards
binding/SkiaSharp.NativeAssets.Linux.NoDependencies/buildTransitive/net4/SkiaSharp.targets
Show resolved
Hide resolved
binding/HarfBuzzSharp.NativeAssets.Linux/HarfBuzzSharp.NativeAssets.Linux.csproj
Outdated
Show resolved
Hide resolved
binding/SkiaSharp.NativeAssets.Linux/SkiaSharp.NativeAssets.Linux.csproj
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
I see all the linux tests are failing with :
It could either be that the so is truly not there OR it may be the so is depending on something that is not there. |
Actually, all of my CI is failing with that - even those with no changes... I wonder if the azure devops image is broken somehow. Let me rebuild main and see what happens. |
the fix is #3194 |
Thanks for the work on this PR! |
This build should be on the preview feed as nightly 19 |
@kasperk81 please add linux-bionic build support also 🙏 for arm64, x64 and x86 Architectures |
@aicynide, android has its own package https://www.nuget.org/packages/SkiaSharp.NativeAssets.Android |
Yes you are I think SkiaSharp my work under It would be a huge help if you can provide SQLITEPCL.raw 's Thank you |
@aicynide please open a new issue. |
Hi folks, The builds are now available on the preview feed: https://aka.ms/skiasharp-eap/index.json As soon as you let me know, I can release this to NuGet and then hopefully a stable version shortly afterwards. |
Description of Change
Add linux-riscv64 and linux-musl-riscv64 support. Debian 12 with clang 19 and libfontconfig1_2.15.0-2 (http://deb.debian.org/debian/pool/main/f/fontconfig/) is a good baseline to start.
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist