Issue/12 add method to add post type to zoninator #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoninator Automattic#12 Added a `register_zone_post_type` method to the `Zoninator` class. It more easily allows users to add additional post types to zones. It accepts one parameter, `$post_types`, and it can be either a string of the post type slug, or an array of post type slugs. The method returns a boolean: true if any post types were registered, false if not.
Zoninator Automattic#12 Added a comment for clarification on what the return value of `register_zone_post_type()` represents.
Zoninator Automattic#12 Removed unnecessary empty string check on `$post_type`. `post_type_exists( $post_type )` already handles the check on `$post_type` passing it on to `get_post_type_object()` which checks it with `is_scalar( $post_type)`.
Zoninator Automattic#12 Cleaned up a few code formatting issues.
sboisvert
approved these changes
May 3, 2018
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoninator #12
Added a
register_zone_post_typemethod to theZoninatorclass. It more easily allows users to add additional post types to zones.It accepts one parameter,
$post_types, and it can be either a string of the post type slug, or an array of post type slugs.The method returns a boolean: true if any post types were registered, false if not.