Skip to content

Conversation

@ryanwelcher
Copy link

Adding a filter to allow other post types to be used

@ryanwelcher ryanwelcher changed the title Feature/filter post types Adding filter to $this->default_post_types May 16, 2015
@mjangda
Copy link
Member

mjangda commented Jun 11, 2015

Since the root issue is that the default_post_types property doesn't updated when additional post_types are added/removed from zoninator, we should fix that instead. Otherwise, we make adding post_type support even harder (you have to call add_post_type_support AND filter this AND ...).

@mjangda
Copy link
Member

mjangda commented Jun 11, 2015

Admittedly, this filter makes it pretty easy to add post type support but goes against the typical WordPress-way of adding post_type support. I think I'll need to think on it or additional feedback/viewpoints :)

@bcampeau
Copy link
Contributor

👍 to @mjangda I agree on that

@ryanwelcher
Copy link
Author

Thanks for your feedback! I have taken a different approach based on your comments and issued a new pull request on a different branch - #34

@GaryJones
Copy link
Contributor

Fixed with #73.

@GaryJones GaryJones closed this Aug 8, 2024
@GaryJones GaryJones added the status: duplicate This issue or pull request already exists label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants