Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Remove automated-migration/collect-credentials feature flag and references to SOURCE_URL step #97661

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented Dec 19, 2024

Proposed Changes

  • Remove all references to automated-migration/collect-credentials from /setup/migration and /setup/site-migration (and hosted-site-migration as consequence)
  • Remove all references to the old migration-source-url step, which only captured the user domain. Now, we can capture way more data with the credentials step.
  • Delete the test cases the feature is off

Why are these changes being made?

  • Code cleanup to improve maintenance

Testing Instructions

  • Go to any of our migration flows (e.g./setup/hosted-site-migration)
  • Choose DIFM
  • Follow the steps and check if you can see the credentials setup

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires added the [Feature] Site Migration Features related to site migrations to WPcom label Dec 19, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~136 bytes removed 📉 [gzipped])

name                        parsed_size           gzip_size
site-migration-flow              -275 B  (-0.2%)      -44 B  (-0.2%)
hosted-site-migration-flow       -275 B  (-0.2%)      -44 B  (-0.2%)
migration-flow                   -201 B  (-0.2%)      -75 B  (-0.4%)
import-hosted-site-flow          -114 B  (-0.0%)      -17 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires self-assigned this Dec 19, 2024
@gabrielcaires gabrielcaires requested a review from a team December 19, 2024 18:28
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 19, 2024
@gabrielcaires gabrielcaires marked this pull request as ready for review December 19, 2024 18:29
@gabrielcaires gabrielcaires changed the title MIgrations: Remove automated-migration/collect-credentials feature flag and references to SOURCE_URL step Site Migration: Remove automated-migration/collect-credentials feature flag and references to SOURCE_URL step Dec 19, 2024
Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants