-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Odie] Wapuu scroll rework #93145
[Odie] Wapuu scroll rework #93145
Conversation
b23c806
to
76da52d
Compare
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~707 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
… as well as refactoring and keep improving scrolling
bfef3a6
to
81ffaac
Compare
This is a rework on how the scrolling is working in Wapuu client, as well as a better handling for extra contact flows.
#93109
#93108
Proposed Changes
The changes are still using React References, but this time only for the parent element. This way we can safely and easily iterate on children looking for tags (is last element, is last user message, is error message, is feedback message, etc). That way we improve greatly the control over the scrolling.
Main changes
Why are these changes being made?
We needed urgently to update the user experience with the scrolling
Testing Instructions
Check scroll behavior
Check contact flows