Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action: fix escaping for brackets in the apply-stale-closure-label.yml. #80489

Merged
merged 1 commit into from
Aug 11, 2023
Merged

GitHub Action: fix escaping for brackets in the apply-stale-closure-label.yml. #80489

merged 1 commit into from
Aug 11, 2023

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Aug 11, 2023 •
edited
Loading

Related to #80358.

Proposed Changes

This PR fixes the escaping of [] brackets in the label.

Testing Instructions

n/a.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@worldomonation
Update apply-stale-closure-label.yml
1f7401a 
.github/workflows/apply-stale-closure-label.yml
- escape the brackets
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-77073
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-77073&env=jetpack

@worldomonation worldomonation marked this pull request as ready for review August 11, 2023 07:09
@worldomonation worldomonation requested a review from a team as a code owner August 11, 2023 07:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 11, 2023
@worldomonation worldomonation self-assigned this Aug 11, 2023
@worldomonation worldomonation merged commit 88727da into trunk Aug 11, 2023
7 of 8 checks passed
@worldomonation worldomonation deleted the fix/github-actions-stale-label branch August 11, 2023 07:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 11, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@worldomonation worldomonation

Labels
None yet
Projects
KitKat Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worldomonation @matticbot