Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Triage: add workflow to automatically apply the [Status] Stale label for issues closed with a keyword. #80358

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

worldomonation
Copy link
Contributor

@worldomonation worldomonation commented Aug 9, 2023

Context: p1691054833018099-slack-CQD1HH4MA

Proposed Changes

This PR adds a GitHub workflow to automatically add the label (shown above) to issues that KitKat closes with the agreed-upon predef.

The aim for this workflow is to make sure we appropriately label issues closed under this Stale issue effort for future reporting purposes.

Testing Instructions

Cannot be tested until merged and running.

That said, I have tested a near-identical copy of the workflow in another repository to make sure it works.
Example issue: Automattic/wp-calypso-test-results#23
Workflow: https://github.com/Automattic/wp-calypso-test-results/blob/trunk/.github/workflows/label.yml

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

- new workflow to add stale closure label if warranted on closed issues.
- add control character escaping
@worldomonation worldomonation self-assigned this Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@worldomonation worldomonation marked this pull request as ready for review August 9, 2023 15:07
@worldomonation worldomonation requested a review from a team as a code owner August 9, 2023 15:07
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 9, 2023
- name: Set Last Comment
id: get_last_comment
run: |
last_comment=$( echo '${{ steps.get_all_comments.outputs.data }}' | tr -d '[:cntrl:]' | jq -r '.[-1].body' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm not too familiar with the workflow.)

steps.get_all_comments.outputs.data

question: The ID used in the previous step was get_comments. But, get_all_comments is being referenced here. Shouldn't the reference be ${{ steps.get_comments.outputs.data }}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you for your eagle-eyed observation!

- fix mismatch between step id
@worldomonation worldomonation merged commit 08bc167 into trunk Aug 11, 2023
3 checks passed
@worldomonation worldomonation deleted the add/apply-stale-closure-label-workflow branch August 11, 2023 02:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants