Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Customize Woo Express and free trial themes screen (#78570)" #78732

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

ilyasfoo
Copy link
Contributor

This reverts commit be324ec.

Reference: p1687950209264639/1687889632.741609-slack-C03Q87XT1QF

@ilyasfoo ilyasfoo requested a review from a team as a code owner June 28, 2023 11:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

@ilyasfoo ilyasfoo removed the request for review from a team June 28, 2023 11:27
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2009 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
themes                               -1069 B  (-0.1%)     -294 B  (-0.1%)
settings-performance                 -1040 B  (-0.2%)     -190 B  (-0.1%)
write-flow                           -1014 B  (-0.1%)     -188 B  (-0.1%)
videopress-flow                      -1014 B  (-0.1%)     -188 B  (-0.1%)
settings-writing                     -1014 B  (-0.2%)     -206 B  (-0.1%)
settings-security                    -1014 B  (-0.3%)     -206 B  (-0.2%)
posts-custom                         -1014 B  (-0.2%)     -188 B  (-0.1%)
posts                                -1014 B  (-0.2%)     -188 B  (-0.1%)
media                                -1014 B  (-0.1%)     -206 B  (-0.1%)
marketing                            -1014 B  (-0.2%)     -212 B  (-0.1%)
link-in-bio-tld-flow                 -1014 B  (-0.1%)     -188 B  (-0.1%)
free-flow                            -1014 B  (-0.1%)     -188 B  (-0.1%)
earn                                 -1014 B  (-0.2%)     -207 B  (-0.2%)
build-flow                           -1014 B  (-0.1%)     -188 B  (-0.1%)
activity                             -1014 B  (-0.2%)     -190 B  (-0.1%)
theme                                 -929 B  (-0.1%)     -189 B  (-0.1%)
plugins                               -734 B  (-0.0%)     -167 B  (-0.0%)
jetpack-cloud-plugin-management       -734 B  (-0.1%)     -167 B  (-0.1%)
hosting                               -734 B  (-0.1%)     -144 B  (-0.1%)
settings                              -721 B  (-0.1%)     -166 B  (-0.1%)
domains                               -713 B  (-0.0%)     -150 B  (-0.0%)
checkout                              +354 B  (+0.0%)      +69 B  (+0.0%)
pattern-assembler-step                 +85 B  (+0.0%)      +36 B  (+0.0%)
marketplace                            +85 B  (+0.0%)      +15 B  (+0.0%)
import-flow                            +85 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1911 bytes removed 📉 [gzipped])

name                                                     parsed_size           gzip_size
async-load-design-blocks                                     -1014 B  (-0.1%)     -188 B  (-0.0%)
async-load-calypso-reader-sidebar                            -1014 B  (-1.4%)     -191 B  (-1.0%)
async-load-calypso-post-editor-editor-media-modal            -1014 B  (-0.1%)     -206 B  (-0.1%)
async-load-calypso-my-sites-stats-summary                    -1014 B  (-2.1%)     -209 B  (-1.5%)
async-load-calypso-my-sites-stats-stats-subscribers          -1014 B  (-1.0%)     -187 B  (-0.5%)
async-load-calypso-my-sites-stats-stats-insights             -1014 B  (-1.3%)     -219 B  (-1.0%)
async-load-calypso-my-sites-current-site-notice              -1014 B  (-2.9%)     -169 B  (-1.7%)
async-load-calypso-components-web-preview-component          -1014 B  (-0.2%)     -188 B  (-0.1%)
async-load-calypso-blocks-jitm-templates-sidebar-banner      -1014 B  (-4.5%)     -180 B  (-2.7%)
async-load-calypso-blocks-jitm-templates-notice              -1014 B  (-4.5%)     -180 B  (-2.7%)
async-load-calypso-blocks-jitm-templates-default             -1014 B  (-4.5%)     -182 B  (-2.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ilyasfoo
Copy link
Contributor Author

Merging since it's a revert and I've tested

@ilyasfoo ilyasfoo merged commit 7908cf6 into trunk Jun 28, 2023
@ilyasfoo ilyasfoo deleted the revert/78570 branch June 28, 2023 12:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants