Customize Woo Express and free trial themes screen

[ilyasfoo]

Related to Automattic/wc-calypso-bridge#1181

Proposed Changes

Implement theme page customizations for Woo Express free trial sites.

• Add a hidden theme filter mechanism to append filters that do not show up in UI or URL
• Add woo-on-plans hidden filter for WooCommerce themes
• Hide theme categories from theme filters UI
• Update WooCommerce themes to show the congratulations page after activating
• Update Woo Express and free trial selectors to optimistically use site state data while plan data is loaded

Testing Instructions

• If D114232-code is not yet merged, you'll need to sandbox it and point public-api.wordpress.com to your sandbox
• In a free trial or Woo Express site, go to Appearance > Themes
• Observe that only WooCommerce themes appear
• Observe that the categories filter is not shown
• Observe that the banner copy is Upgrade to a plan to upload your own themes!
• Click on the banner CTA, it should navigate you to the plans page
• Go back to Appearance > Themes and activate a theme different to your current theme
• Observe that you're redirected to the Congratulations screen

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-71818

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-71818&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2036 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
themes                               +1069 B  (+0.1%)     +294 B  (+0.1%)
settings-performance                 +1040 B  (+0.2%)     +190 B  (+0.1%)
write-flow                           +1014 B  (+0.1%)     +188 B  (+0.1%)
videopress-flow                      +1014 B  (+0.1%)     +188 B  (+0.1%)
settings-writing                     +1014 B  (+0.2%)     +206 B  (+0.1%)
settings-security                    +1014 B  (+0.3%)     +206 B  (+0.2%)
posts-custom                         +1014 B  (+0.2%)     +188 B  (+0.1%)
posts                                +1014 B  (+0.2%)     +188 B  (+0.1%)
media                                +1014 B  (+0.1%)     +206 B  (+0.1%)
marketing                            +1014 B  (+0.2%)     +212 B  (+0.1%)
link-in-bio-tld-flow                 +1014 B  (+0.1%)     +188 B  (+0.1%)
free-flow                            +1014 B  (+0.1%)     +188 B  (+0.1%)
earn                                 +1014 B  (+0.2%)     +207 B  (+0.2%)
build-flow                           +1014 B  (+0.1%)     +188 B  (+0.1%)
activity                             +1014 B  (+0.2%)     +190 B  (+0.1%)
theme                                 +929 B  (+0.1%)     +189 B  (+0.1%)
plugins                               +734 B  (+0.0%)     +195 B  (+0.0%)
jetpack-cloud-plugin-management       +734 B  (+0.1%)     +195 B  (+0.1%)
hosting                               +734 B  (+0.1%)     +144 B  (+0.1%)
settings                              +721 B  (+0.1%)     +166 B  (+0.1%)
domains                               +713 B  (+0.0%)     +150 B  (+0.0%)
checkout                              -354 B  (-0.0%)      -69 B  (-0.0%)
pattern-assembler-step                 -85 B  (-0.0%)      -37 B  (-0.0%)
marketplace                            -85 B  (-0.0%)      -15 B  (-0.0%)
import-flow                            -85 B  (-0.0%)      -37 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1911 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-design-blocks                                     +1014 B  (+0.1%)     +188 B  (+0.0%)
async-load-calypso-reader-sidebar                            +1014 B  (+1.4%)     +191 B  (+1.0%)
async-load-calypso-post-editor-editor-media-modal            +1014 B  (+0.1%)     +206 B  (+0.1%)
async-load-calypso-my-sites-stats-summary                    +1014 B  (+2.1%)     +209 B  (+1.5%)
async-load-calypso-my-sites-stats-stats-subscribers          +1014 B  (+1.0%)     +187 B  (+0.5%)
async-load-calypso-my-sites-stats-stats-insights             +1014 B  (+1.4%)     +219 B  (+1.0%)
async-load-calypso-my-sites-current-site-notice              +1014 B  (+3.0%)     +169 B  (+1.7%)
async-load-calypso-components-web-preview-component          +1014 B  (+0.2%)     +188 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-sidebar-banner      +1014 B  (+4.7%)     +180 B  (+2.8%)
async-load-calypso-blocks-jitm-templates-notice              +1014 B  (+4.7%)     +180 B  (+2.8%)
async-load-calypso-blocks-jitm-templates-default             +1014 B  (+4.7%)     +182 B  (+2.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ilyasfoo]

It seems site data also has the current plan slug. This is necessary for better UX since site data is already available when the themes screen is loaded. Otherwise, we'll have the upsell component flicker in-and-out and the themes list not loading properly since hidden filter is added after its first load.

[chihsuan]

Thanks for working on this! Looks good and tested well. 👍

[JessBoctor]

I did a functional review. There was only one thing that didn't work as expected:

[x] Observe that only WooCommerce themes appear

[] Observe that the categories filter is not shown - For me, the categories still appeared but I was not shown any results when I clicked on them. This made things feel a little bit broken:

[x] Observe that the banner copy is Upgrade to a plan to upload your own themes!
[x] Click on the banner CTA, it should navigate you to the plans page
[x] Go back to Appearance > Themes and activate a theme different to your current theme
[x] Observe that you're redirected to the Congratulations screen

Environment:

• D114232 Patch on sandbox
• Checked out add/1181-wooexpress-custom-theme
• Sandboxed WordPress.com, public-api.wordpress.com, and Calypso
• new WooExpress trial site from woocommerce.com/start
• Browser: Chrome Version 114.0.5735.133
• macOS: 13.4 Ventura

[moon0326]

Nice work on this!

LGTM and tested well for me 👍 🚀

[ilyasfoo]

Hi, @JessBoctor! Thanks for the review!

[] Observe that the categories filter is not shown - For me, the categories still appeared but I was not shown any results when I clicked on them. This made things feel a little bit broken:

Sorry this wasn't clear in the instructions. The categories in this context are these: