Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Woo Express site provisioning loading messages #77051

Merged
merged 2 commits into from
May 19, 2023

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented May 18, 2023

Related to #75273 and #74691

Proposed Changes

Changes to Woo Express site provisioning loading messages:

  • Initial message set to Hang tight! Your free trial is currently being set up and may take a few minutes.
  • Reduced duration of various Woo facts – not all facts are able to be shown (4 out of 6 facts was shown in the video, may vary if loading times are longer/shorter).
  • Just before being redirected, the message We're almost there! Your free trial will be ready in just a moment. is shown.
  • Bold initial words in the tagline
  • Fixed letter spacing
  • Fixed responsive view

Testing Instructions

  • Go to http://calypso.localhost:3000/setup/wooexpress
  • Observe the loading messages per highlighted in above changes
  • While loading, try to reduce browser width down to 400 - 500px and observe the loading bar does not overflow the screen
image
EHMpk6.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented May 18, 2023

@matticbot
Copy link
Contributor

matticbot commented May 18, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~97 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +404 B  (+0.0%)      +97 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~18 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
trial-wooexpress-flow        +64 B  (+0.2%)      +18 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ilyasfoo ilyasfoo requested review from a team, chihsuan and rjchow May 18, 2023 14:01
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 18, 2023
Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating it. LGTM and tested well. 🚢

@ilyasfoo ilyasfoo merged commit 807306d into trunk May 19, 2023
@ilyasfoo ilyasfoo deleted the tweak/75273-wooexpress-loading-screen-messages branch May 19, 2023 03:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 19, 2023
@ilyasfoo ilyasfoo linked an issue May 19, 2023 that may be closed by this pull request
5 tasks
@a8ci18n
Copy link

a8ci18n commented May 19, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7997973

Thank you @ilyasfoo for including a screenshot in the description! This is really helpful for our translators.

@ilyasfoo ilyasfoo linked an issue May 19, 2023 that may be closed by this pull request
@a8ci18n
Copy link

a8ci18n commented May 25, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Create a bank of 30 #FunWooFacts for use in Woo loading screens Free trial: Loading screen mobile view
5 participants