Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace Thank You: Centralize footer #76429

Merged
merged 1 commit into from
May 2, 2023

Conversation

WBerredo
Copy link
Contributor

Proposed Changes

Remove lateral padding and update width to make the footer items to be centralized

Testing Instructions

  • Install a plugin or a theme (or both)
  • On the Marketplace Thank You page check if the footer items are centralized
Before After
CleanShot 2023-04-28 at 15 26 10@2x CleanShot 2023-04-28 at 15 27 56@2x

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@WBerredo WBerredo self-assigned this Apr 28, 2023
@WBerredo WBerredo requested a review from a team as a code owner April 28, 2023 18:30
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 28, 2023
@matticbot
Copy link
Contributor

matticbot commented Apr 28, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Below are two screenshots taken using Firefox that add some lines when selecting elements in the HTML. I have also added two identical red squares to compare
CleanShot 2023-05-02 at 16 33 33@2x
CleanShot 2023-05-02 at 16 34 09@2x

@WBerredo WBerredo merged commit e994fff into trunk May 2, 2023
@WBerredo WBerredo deleted the update/marketplace-thank-you-footer-centralize branch May 2, 2023 16:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants