Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace Thank You: Guarantee 3 sections on footer #76427

Merged
merged 4 commits into from
May 3, 2023

Conversation

WBerredo
Copy link
Contributor

@WBerredo WBerredo commented Apr 28, 2023

Proposed Changes

  • Update the architecture of footer steps to allow more flexibility in the ordering of the items
  • Create a theme support section
  • Update all cases(only plugins, only themes, multiple types) to have 3 sections

CleanShot 2023-04-28 at 14 42 18@2x

Testing Instructions

  • Install a plugin
  • Check if the Marketplace Thank You footer is similar to the image below
  • Install a theme
  • Check if the Marketplace Thank You footer is similar to the image below
  • Purchase a plugin along with a theme
  • Check if the Marketplace Thank You footer is similar to the image below
Plugin Theme Plugin + Theme
CleanShot 2023-04-28 at 14 39 41@2x CleanShot 2023-04-28 at 14 40 03@2x CleanShot 2023-04-28 at 14 40 50@2x

Related to #76429

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@WBerredo WBerredo requested review from JanaMW27 and vinimotaa April 28, 2023 17:44
@WBerredo WBerredo self-assigned this Apr 28, 2023
@WBerredo WBerredo requested a review from a team as a code owner April 28, 2023 17:44
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 28, 2023
@WBerredo WBerredo changed the title Marketplace Thank You: Guarantee at least 3 sections on footer Marketplace Thank You: Guarantee 3 sections on footer Apr 28, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~60 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
marketplace       +381 B  (+0.0%)      +60 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it, and it works as advertised. LGTM! 🚢

An additional follow-up task that I would suggest is the alignment of the footer steps. Due to the left alignment of the text and some right padding on the cards, it looks like they are not correctly aligned (although they are) so it would be great to tackle this
CleanShot 2023-05-02 at 11 22 15@2x

@JanaMW27
Copy link

JanaMW27 commented May 2, 2023

I've reviewed it, and in every case, I've seen 3 elements. I have to say, though, that the margins in each case look funny as pointed out in a comment above.

@WBerredo
Copy link
Contributor Author

WBerredo commented May 2, 2023

An additional follow-up task that I would suggest is the alignment of the footer steps.

I forgot to link it here, but the centralization task is already in review #76429 and I would love your input there.

cc: @epeicher @JanaMW27

@WBerredo WBerredo merged commit 1356c1f into trunk May 3, 2023
@WBerredo WBerredo deleted the update/marketplace-thank-you-footer-sections branch May 3, 2023 12:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 3, 2023
@a8ci18n
Copy link

a8ci18n commented May 3, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7965809

Thank you @WBerredo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 11, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants