-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace Thank You: Guarantee 3 sections on footer #76427
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~60 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it, and it works as advertised. LGTM! 🚢
An additional follow-up task that I would suggest is the alignment of the footer steps. Due to the left alignment of the text and some right padding on the cards, it looks like they are not correctly aligned (although they are) so it would be great to tackle this
I've reviewed it, and in every case, I've seen 3 elements. I have to say, though, that the margins in each case look funny as pointed out in a comment above. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7965809 Thank you @WBerredo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
Related to #76429
Pre-merge Checklist