Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free Flow: Add blog title to free flow createSiteWithCart() #71429

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Dec 21, 2022

Proposed Changes

  • Pass site title (blog title) to createSiteWithCart() function for free flow step creation step.
    This PR requires backend diff: D96193-code

Testing Instructions

  1. Check out this PR
  2. Setup backend diff: D96193-code
  3. Go through the free flow (/setup/free).

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Related to #

@agrullon95 agrullon95 self-assigned this Dec 21, 2022
@github-actions
Copy link

github-actions bot commented Dec 21, 2022

@sharpirate
Copy link
Contributor

✔️ This tests well, it's generating domains based on my username (sharpirate) such as shadysharpirate.wordpress.com, beardedsharpirate.wordpress.com etc.

@agrullon95 agrullon95 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 21, 2022
@agrullon95 agrullon95 changed the title Add blog title to free flow createSiteWithCart() Free Flow: Add blog title to free flow createSiteWithCart() Dec 21, 2022
@jeyip
Copy link
Contributor

jeyip commented Dec 21, 2022

Testing

Requirements

  • Can complete the free flow and create a new site
  • Newly created site's slug matches the site title
  • If site slug with given site title is already assigned, site slug matches the site title with a numeric modifier ( mytestsite -> mytestsite1 )
  • Site titles with special characters lead to creation of a site slug with an adjective + username

Browsers

  • Chrome

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~41 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
tailored-ecommerce-flow        +98 B  (+0.0%)      +18 B  (+0.0%)
link-in-bio-tld-flow           +98 B  (+0.0%)      +18 B  (+0.0%)
link-in-bio-flow               +98 B  (+0.0%)      +18 B  (+0.0%)
free-flow                      +98 B  (+0.0%)      +23 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@edanzer
Copy link
Contributor

edanzer commented Dec 22, 2022

This is testing well for me! I ran through free flow three times:

  • First time I used a unique title with no special chars. That title was used as the domain.
  • Second time I used the same title again. Domain was that title + a number.
  • Third time I used the same title but inserted a special char. The domain selected was adjective + username.

I did notice that the at the end of the flow, the site wasn't launching correctly - it was continually redirecting back to launchpad. But I've confirmed this is just because the backend diff is missing some recent launchpad.php changes and just needs to be rebased. Going to approve this in any case as the backend diff is separate.

I did also tested the backend diff on it's own per testing instruction on that diff - just manually generating name combinations, and that's working well too.

Copy link
Contributor

@sharpirate sharpirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Did a quick retest so I'm approving the PR

@agrullon95 agrullon95 merged commit 4af60e6 into trunk Jan 4, 2023
@agrullon95 agrullon95 deleted the add/free-flow-domain-generation branch January 4, 2023 18:47
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants