-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free Flow: Add blog title to free flow createSiteWithCart() #71429
Conversation
✔️ This tests well, it's generating domains based on my username (sharpirate) such as |
TestingRequirements
Browsers
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~41 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This is testing well for me! I ran through free flow three times:
I did notice that the at the end of the flow, the site wasn't launching correctly - it was continually redirecting back to launchpad. But I've confirmed this is just because the backend diff is missing some recent launchpad.php changes and just needs to be rebased. Going to approve this in any case as the backend diff is separate. I did also tested the backend diff on it's own per testing instruction on that diff - just manually generating name combinations, and that's working well too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Did a quick retest so I'm approving the PR
Proposed Changes
createSiteWithCart()
function for free flow step creation step.This PR requires backend diff: D96193-code
Testing Instructions
/setup/free
).Pre-merge Checklist
Related to #