Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/mailbox link professional email without feature flags #64986

Merged
merged 12 commits into from
Jun 28, 2022
Merged

Update/mailbox link professional email without feature flags #64986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
764506c
Adding feature flags
AllTerrainDeveloper May 16, 2022
ebe78b1
Better naming
AllTerrainDeveloper May 17, 2022
387e28c
Emails: Better namings
AllTerrainDeveloper May 20, 2022
31aa831
Open embedded mailbox in the same tab
AllTerrainDeveloper May 25, 2022
545fd98
Update Test URL for Professional Email
AllTerrainDeveloper May 31, 2022
78895c6
Update URLS
AllTerrainDeveloper Jun 3, 2022
9e4d8c8
Initial code to update thank you page
AllTerrainDeveloper Jun 17, 2022
83487eb
Emails: Add redirect & Email parameters to the Professional Email client
AllTerrainDeveloper Jun 27, 2022
ac47d80
Emails: Remove TEMPORARILY Contact & Calendar apps
AllTerrainDeveloper Jun 27, 2022
5abf215
Emails: Linting
AllTerrainDeveloper Jun 27, 2022
e73b7fe
Emails: Add suggestions
AllTerrainDeveloper Jun 28, 2022
25e9097
Emails: Fix build
AllTerrainDeveloper Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Emails: Add suggestions
  • Loading branch information
@AllTerrainDeveloper
AllTerrainDeveloper committed Jun 28, 2022
commit e73b7feb50e76194881576dec9e27cacf60b692c
3 changes: 0 additions & 3 deletions client/assets/images/email-providers/titan/services/flat/calendar.svg
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions client/assets/images/email-providers/titan/services/flat/contacts.svg
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions client/lib/titan/get-titan-urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ export function getTitanAppsUrlPrefix( domain ) {
* @param {string?} email - The email address of the Titan account. Used for autofill on Titan's login page.
* @param {string?} app - Can be one of the `TITAN_APPS` - `email`, `calendar` or `contacts`
* @param {boolean?} clearPreviousSessions - Whether to clear previously logged-in sessions.
* @returns The URL with app and prefilled `email_account` as query parameter
* @param {string?} redirectUrl - Where the Professional Email client should redirect the user back to WordPress.
* @returns {string} The URL with app and prefilled `email_account` as query parameter
*/
function getTitanUrl(
titanAppsUrlPrefix,
Expand All @@ -50,14 +51,6 @@ function getTitanUrl(
return titanAppUrl.href;
}

export function getTitanCalendarUrl( titanAppsUrlPrefix, email ) {
return getTitanUrl( titanAppsUrlPrefix, email, TITAN_APPS.CALENDAR );
}

export function getTitanContactsUrl( titanAppsUrlPrefix, email ) {
return getTitanUrl( titanAppsUrlPrefix, email, TITAN_APPS.CONTACTS );
}

/**
* Gets the Web client URL for Professional Email
*
Expand Down
1 change: 0 additions & 1 deletion client/my-sites/checkout/checkout-thank-you/domains/thank-you-content/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const StepCTA = ( { email, primary, domainType }: StepCTAProps ) => {
return (
<FullWidthButton
href={ getTitanEmailUrl( titanAppsUrlPrefix, email, true ) }
target="_blank"
primary={ primary }
onClick={ () => {
recordEmailAppLaunchEvent( {
Expand Down
1 change: 0 additions & 1 deletion client/my-sites/email/inbox/mailbox-selection-list/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import './style.scss';

const getExternalUrl = ( mailbox, titanAppsUrlPrefix ) => {
if ( isTitanMailAccount( mailbox ) ) {

return getTitanEmailUrl(
titanAppsUrlPrefix,
getEmailAddress( mailbox ),
Expand Down