-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/mailbox link professional email without feature flags #64986
Update/mailbox link professional email without feature flags #64986
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~298 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~31 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one unit test that is failing, and I would suggest removing code that is no longer used (we don't know when Titan will support the links for the Calendar and Contacts apps - maybe it will never happen 🙂). But otherwise feel free to ship it 🚢🎉.
Changes proposed in this Pull Request
Adds redirect url and email to the Professional Email embedded inbox. We are also removing TEMPORARILY two menu items, Calendar & Contact
![image](https://user-images.githubusercontent.com/5689927/175997945-0c457ae7-aa0c-423d-ac78-162a0c20c34f.png)
Testing instructions