Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/mailbox link professional email without feature flags #64986

Conversation

AllTerrainDeveloper
Copy link
Contributor

@AllTerrainDeveloper AllTerrainDeveloper commented Jun 27, 2022

Changes proposed in this Pull Request

Adds redirect url and email to the Professional Email embedded inbox. We are also removing TEMPORARILY two menu items, Calendar & Contact
image

Testing instructions

  1. Have a Professional Email account
  2. Access it through the Inbox menu in the calypso sidebar
  3. It should prompt you to use your password (or log in if you are already authenticated)
  4. The Look & Feel should have a black top bar with the WordPress logo (Similar to our dashboard)

@AllTerrainDeveloper AllTerrainDeveloper self-assigned this Jun 27, 2022
@AllTerrainDeveloper AllTerrainDeveloper requested a review from a team June 27, 2022 12:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jun 27, 2022

@matticbot
Copy link
Contributor

matticbot commented Jun 27, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~298 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
email                          -802 B  (-0.1%)     -111 B  (-0.1%)
checkout                       -130 B  (-0.0%)       -8 B  (-0.0%)
woocommerce-installation        -73 B  (-0.0%)      -28 B  (-0.0%)
woocommerce                     -73 B  (-0.0%)      -28 B  (-0.0%)
themes                          -73 B  (-0.0%)      -28 B  (-0.0%)
theme                           -73 B  (-0.0%)      -28 B  (-0.0%)
stats                           -73 B  (-0.0%)      -28 B  (-0.0%)
sites                           -73 B  (-0.0%)      -28 B  (-0.0%)
site-purchases                  -73 B  (-0.0%)      -29 B  (-0.0%)
settings-writing                -73 B  (-0.0%)      -29 B  (-0.0%)
settings-security               -73 B  (-0.0%)      -28 B  (-0.0%)
settings-performance            -73 B  (-0.0%)      -28 B  (-0.0%)
settings-jetpack                -73 B  (-0.0%)      -28 B  (-0.0%)
settings-discussion             -73 B  (-0.0%)      -28 B  (-0.0%)
settings                        -73 B  (-0.0%)      -29 B  (-0.0%)
scan                            -73 B  (-0.0%)      -28 B  (-0.0%)
purchases                       -73 B  (-0.0%)      -29 B  (-0.0%)
preview                         -73 B  (-0.0%)      -28 B  (-0.0%)
posts-custom                    -73 B  (-0.0%)      -28 B  (-0.0%)
posts                           -73 B  (-0.0%)      -27 B  (-0.0%)
plugins                         -73 B  (-0.0%)      -30 B  (-0.0%)
plans                           -73 B  (-0.0%)      -28 B  (-0.0%)
people                          -73 B  (-0.0%)      -28 B  (-0.0%)
pages                           -73 B  (-0.0%)      -28 B  (-0.0%)
migrate                         -73 B  (-0.0%)      -28 B  (-0.0%)
media                           -73 B  (-0.0%)      -31 B  (-0.0%)
marketplace                     -73 B  (-0.0%)      -30 B  (-0.0%)
marketing                       -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-social                  -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-search                  -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-connect                 -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-cloud-settings          -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-cloud-pricing           -73 B  (-0.0%)      -28 B  (-0.0%)
jetpack-cloud                   -73 B  (-0.0%)      -28 B  (-0.0%)
incoming-redirect               -73 B  (-0.3%)      -33 B  (-0.4%)
import                          -73 B  (-0.0%)      -28 B  (-0.0%)
hosting                         -73 B  (-0.0%)      -28 B  (-0.0%)
home                            -73 B  (-0.0%)      -28 B  (-0.0%)
gutenberg-editor                -73 B  (-0.0%)      -28 B  (-0.0%)
google-my-business              -73 B  (-0.0%)      -28 B  (-0.0%)
export                          -73 B  (-0.0%)      -28 B  (-0.0%)
earn                            -73 B  (-0.0%)      -28 B  (-0.0%)
domains                         -73 B  (-0.0%)      -29 B  (-0.0%)
customize                       -73 B  (-0.0%)      -28 B  (-0.0%)
concierge                       -73 B  (-0.0%)      -28 B  (-0.0%)
comments                        -73 B  (-0.0%)      -28 B  (-0.0%)
backup                          -73 B  (-0.0%)      -28 B  (-0.0%)
activity                        -73 B  (-0.0%)      -28 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~31 bytes removed 📉 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal        -73 B  (-0.0%)      -31 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@stephanethomas stephanethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one unit test that is failing, and I would suggest removing code that is no longer used (we don't know when Titan will support the links for the Calendar and Contacts apps - maybe it will never happen 🙂). But otherwise feel free to ship it 🚢🎉.

@AllTerrainDeveloper AllTerrainDeveloper requested a review from a team as a code owner June 28, 2022 12:08
@AllTerrainDeveloper AllTerrainDeveloper merged commit bd990af into trunk Jun 28, 2022
@AllTerrainDeveloper AllTerrainDeveloper deleted the update/mailbox-link-professional-email-without-feature-flags branch June 28, 2022 14:06
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants