-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Revisions: Rework layout of main post revisions containers #20232
Conversation
|
||
@include breakpoint( '>660px' ) { | ||
border-left: 1px solid darken($sidebar-bg-color, 5%); | ||
z-index: 1; // Put the list above the action-buttons:before overlay gradient. -shaun | ||
width: 230px; | ||
bottom: 73px; | ||
flex-basis: 230px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On desktop the flex-basis defines the width.
left: 0; | ||
height: 120px; | ||
} | ||
flex-basis: 120px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile the flex-basis defines the height thanks to flex-direction: column-reverse;
@shaunandrews -- I'd appreciate a quick pass on this if you have a second. |
This is working well on Chrome for me -- we should test on Edge once #20186 is merged & this rebased. |
cbc7ba3
to
dc2e142
Compare
I managed to break the site switcher with this PR. Steps to reproduce:
You'll get something like this: You should get something like this, with a search input and a message about hidden sites (if you have any): There's a little scrolling lag in Safari as the revisions load, but after a few seconds it seems to resolve itself. I'm sad mobile is still "turned off," but I get the reasoning (performance issues related to client-side diff'ing). Otherwise, this looks good. |
Thanks for having a look at the PR and reporting this issue, @shaunandrews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR
How to test
Repeat the following in Chrome, Safari, Firefox & Edge
(if you're missing any you could use browserstack.com)
History
button to trigger the Post Revisions modalCross-browser testing
Chrome
Everything should look like before.
In addition, all content should now always stay in the modal, even when resizing erratically.
Safari
Safari should now always display the diff content after it's been computed.
No weird hardware acceleration hack needed anymore, it just works. Fixes #20000 .
Firefox
Surf around, any intermittent glitches observed previously should be gone.
If you don't spot anything that's a good sign :)
Edge
Yep, even Edge should look good now. 🎉