Post revisions: Make diff content visible on MS Edge Win 10 #20186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The Issue was caused by using
window.scrollTo
on an element. Webkit based browsers and Firefox auto-correct the behavior and allow the use ofwindow.scrollTo
on an element as well. IE/Edge, on the other hand, is less forgiving. So in Edge, this caused an error that stopped further execution and thus prevented the revision content from being displayed. The straightforward solution to the problem is to useElement.scrollTop
instead.How to test
(Tip: If you don't have a local version you can use our browserstack.com account.)
History
button to trigger the Post Revisions modalNext:
Before
After