Use 'Withdrawal' and 'Deducted' labels when referring to withdrawal deposits, to more accurately communicate the type of transaction that has occurred #9500
+1,363
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinksi
changed the title
Jinksi
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +188 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
…atch changes to withdrawal status label
Jinksi
added
needs tests
|
Ready for review – note I'll be adding some additional integration tests to ensure the new withdrawal labels are rendered correctly, as mentioned in the PR description TODO. |
Jinksi
commented
Oct 1, 2024
| placeholder="" | ||
| role="combobox" | ||
| type="text" | ||
| value="" | ||
| /> | ||
| <span | ||
| class="screen-reader-text" | ||
| id="search-inline-input-15" | ||
| id="search-inline-input-16" |
There was a problem hiding this comment.
These snapshot changes to the rendered HTML id numbers can be ignored – this occurs because I've added a new test case being rendered, bumping many of these ids by +1.
|
PHP/e2e GH actions failing due to error when downloading from |
|
Apologies for the large diff – rest assured this is not as large as it seems, once you see past the new test snapshots introduced. |
Manual testThe changes test well on a manual test 🥇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7802
Changes proposed in this Pull Request
When viewing a 'withdrawal' deposit, the following labels are used:
Deductedinstead ofPaidWithdrawalinstead ofDepositThis applies to the following screens and components:
TODO
Deposit details screen:
Deposit list screen:
Deposit list screen advanced filters:
The option for
paidnow showsPaid / Deducted. Note that we don't support filtering byDeducted, since it is a display/label only and not a status recognised by the WooPayments Server.Payments overview recent deposits list:
Testing instructions
npm run build4000000000000259trunkwithdrawal deposits will appear as typeDepositwith aPaidstatusWithdrawalwith aDeductedstatus (see screenshot above)Status. ThePaidoption has been re-labelled toPaid / Deducted. Note that we don't support filtering byDeducted`, since it is a display/label only and not a status recognised by the WooPayments Server.Deductedstatus appears next to withdrawals on the Payments → Overview recent deposits list.Withdrawal date,DeductedandWithdrawal transactions(see screenshot above)Deposit date,PaidandDeposit transactionsnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge