Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit details shows "paid" and "deposit date" for withdrawals #7802

Open
brucealdridge opened this issue Nov 29, 2023 · 7 comments · May be fixed by #9500
Open

Deposit details shows "paid" and "deposit date" for withdrawals #7802

brucealdridge opened this issue Nov 29, 2023 · 7 comments · May be fixed by #9500
Assignees
Labels
component: deposits Issues related to Deposits focus: deposits priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.

Comments

@brucealdridge
Copy link
Contributor

Describe the bug

On the deposit details page when the amount "deposited" is negative, Stripe has withdrawn the amount from the merchant's account.
Both the Paid status and Deposit date label could be clearer.

image

NB: On the deposits list page, we show correctly that it is a withdrawal.

image

@brucealdridge brucealdridge added type: bug The issue is a confirmed bug. component: deposits Issues related to Deposits category: projects For any issues which are part of any project, including bugs, enhancements, etc. labels Nov 29, 2023
@haszari haszari added priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed category: projects For any issues which are part of any project, including bugs, enhancements, etc. labels Jan 31, 2024
@haszari
Copy link
Contributor

haszari commented Jan 31, 2024

Most merchants don't experience withdrawals, so I've marked as medium priority.

At the same time, this is important – paid is misleading and inaccurate, which could erode trust in WooPayments.

@jessy-p jessy-p self-assigned this Feb 27, 2024
@jessy-p
Copy link
Contributor

jessy-p commented Feb 27, 2024

The "Type" column on the Deposits list page currently displays either Withdrawal or Deposit, depending on whether the amount is negative or not. However, on the Deposit Details page, the "Type" is not displayed. Instead, the "Status" of the deposit is shown, which is marked as "Paid". This labelling is confusing for Withdrawals.

@rogermattic, could you propose some modifications for the Details page to more accurately represent when the deposit is actually a withdrawal by Stripe?

@jessy-p jessy-p removed their assignment Feb 27, 2024
@nagpai nagpai added the needs design The issue requires design input/work from a designer. label Mar 12, 2024
@rogermattic
Copy link

Hey @jessy-p @Rua @brucealdridge

What do you think about swapping wherever we display a Deposit label (we do have that label in many places on this screen :D ) to Withdrawal and then Deducted instead of Paid as a quick fix?
Screenshot 2024-03-13 at 17 02 53

@haszari
Copy link
Contributor

haszari commented Mar 13, 2024

What do you think about swapping wherever we display a Deposit label (we do have that label in many places on this screen :D ) to Withdrawal and then Deducted instead of Paid as a quick fix?

👌🏻 Totally, this is what I was thinking, just switch out the wording for the rare / unfortunate case where we need to pull funds back from merchant.

@rogermattic
Copy link

@haszari Awesome! Thanks:)

@nagpai nagpai removed the needs design The issue requires design input/work from a designer. label Mar 21, 2024
@nagpai
Copy link
Contributor

nagpai commented Mar 22, 2024

@rogermattic - Should the color of the OrderStatus indicator be red for withdrawal?

Image

@rogermattic
Copy link

Hey @nagpai ! Good question, thanks for asking :)
I think we should leave it green as, in my mind, the colour symbolises that the action has been done. We have the status to explain what happened, which should make it clear to the user. Otherwise, the user may be confused and feel as if something wrong has happened. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: deposits Issues related to Deposits focus: deposits priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
7 participants