Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disputes: Update a more clear order note for dispute fund withdrawn event #8371

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Disputes: Update a more clear order note for dispute fund withdrawn event #8371

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90088b8
Update dispute funds withdrawn note text
Mar 12, 2024
623ad9c
Changelog
Mar 12, 2024
bee41a4
Amend changelog as per feedback
Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-6380-edit-dispute-order-note
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix
nagpai marked this conversation as resolved.
Show resolved Hide resolved

Make the order note for `dispute funds withdrawn` event clearly mention that the dispute amount and fee would be deducted from the next deposit
2 changes: 1 addition & 1 deletion includes/class-wc-payments-webhook-processing-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ private function process_webhook_dispute_updated( $event_body ) {

switch ( $event_type ) {
case 'charge.dispute.funds_withdrawn':
$message = __( 'Payment dispute funds have been withdrawn', 'woocommerce-payments' );
$message = __( 'Payment dispute and fees have been deducted from your next deposit', 'woocommerce-payments' );
break;
case 'charge.dispute.funds_reinstated':
$message = __( 'Payment dispute funds have been reinstated', 'woocommerce-payments' );
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test-class-wc-payments-webhook-processing-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,7 +1359,7 @@ public function test_dispute_funds_withdrawn_order_note() {
->method( 'add_order_note' )
->with(
$this->matchesRegularExpression(
'/Payment dispute funds have been withdrawn/'
'/Payment dispute and fees have been deducted from your next deposit/'
)
);

Expand Down
Loading