Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5826: Barnsbury: Fix menu bg w/custom colors #6652

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

#5826: Barnsbury: Fix menu bg w/custom colors #6652

wants to merge 1 commit into from

Conversation

bobmatyas
Copy link
Contributor

@bobmatyas bobmatyas commented Sep 30, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Testing:

  • This only happens on WPCOM
  • Activate Barnsbury, change the color palette
  • Hover over a sub-menu and right-click, it will show the default Barnsbury menu style which isn't consistent with the variations
  • Apply PR and try again, it should fix the issue
Before
Dropdown Menu

Screenshot on 2022-09-30 at 14-37-01

Dropdown Menu when Right Clicking

Screenshot on 2022-09-30 at 14-17-43

After

CLKUv1mVZB thumb

Related issue(s):

Fixes #5826

@bobmatyas bobmatyas requested a review from a team September 30, 2022 18:39
@pbking
Copy link
Contributor

pbking commented Nov 17, 2022

I was still able to reproduce the issue with this change in place:

image

Indeed I could only reproduce on wpcom.

@bobmatyas
Copy link
Contributor Author

Shoot, I thought I had it. I'll try to revisit but it may be a bit since the CSS Guild doesn't have Guide on Duty rotations anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Barnsbury drop down menu colors
2 participants
@bobmatyas @pbking