Skip to content

Add ARM64 app download nudge for users running Intel build under emulation on Windows #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
+13 −13
Open

Add ARM64 app download nudge for users running Intel build under emulation on Windows #1925

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2b3fcfc
Add nudge to download ARM-based Studio app on Windows
ivan-ottinger Oct 24, 2025
6435c84
Simplify warning message logic using platform lookup map
ivan-ottinger Oct 24, 2025
e48747f
Fix lint error
ivan-ottinger Oct 24, 2025
0da14a3
Show ARM64 translation warning on all platforms
ivan-ottinger Oct 24, 2025
1387553
Fix lint error
ivan-ottinger Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,23 +136,23 @@ void Promise.all( [ getIpcApi().getAppGlobals(), getIpcApi().getSentryUserId() ]
window.appGlobals = appGlobals;

// Show warning if running an ARM64 translator
if (
appGlobals.platform === 'darwin' &&
appGlobals.arm64Translation &&
! localStorage.getItem( 'dontShowARM64Warning' )
) {
if ( appGlobals.arm64Translation && ! localStorage.getItem( 'dontShowARM64Warning' ) ) {
const showARM64MessageBox = async () => {
const platformMessages: Record< string, string > = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to match the option we have on the Studio site so it's to the user what they need to download. For macOS it looks good, for Windows is still unknown as far as I know.

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. I will update the text in this PR once we agree on it.

darwin: __(
'Downloading the Mac with Apple Silicon Chip version of Studio will provide better performance.'
),
win32: __( 'Downloading the ARM64 version of Studio will provide better performance.' ),
};

const detailMessage =
platformMessages[ window.appGlobals.platform ] ||
__( 'Downloading the optimized version of Studio will provide better performance.' );

const { response, checkboxChecked } = await getIpcApi().showMessageBox( {
type: 'warning',
message: __( 'This version of Studio is not optimized for your computer' ),
detail:
window.appGlobals.platform === 'darwin'
? __(
'Downloading the Mac with Apple Silicon Chip version of Studio will provide better performance.'
)
: __(
'Downloading the optimized version of Studio will provide better performance.'
),
detail: detailMessage,
checkboxLabel: __( "Don't show this warning again" ),
buttons: [ __( 'Download' ), __( 'Not now' ) ],
cancelId: 1,
Expand Down