-
Couldn't load subscription status.
- Fork 51
Add ARM64 app download nudge for users running Intel build under emulation on Windows #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
📊 Performance Test ResultsComparing e21bbc9 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM but I think we need to wait for #1916 to be merged, to test with both versions.
Meanwhile I confirmed the warning when running the x64 version on my Windows VM.
One thing to consider:
Would it make sense to have the "Download" option automatically download and install the correct version? I believe that should be possible following a similar approach to what we do in the auto-updater.
| ) { | ||
| if ( appGlobals.arm64Translation && ! localStorage.getItem( 'dontShowARM64Warning' ) ) { | ||
| const showARM64MessageBox = async () => { | ||
| const platformMessages: Record< string, string > = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch. I will update the text in this PR once we agree on it.
|
Thank you for the review, Bernardo!
The auto-update process works with the currently running app architecture. I think it could be doable, but at the same time I suspect there could be potential issues if we try to run update from one app architecture to another. Maybe we could explore this once the ARM64 version is out.
Yes, indeed. I think we can wait until the ARM64 version is launched and published on the site and merge this PR for the later Studio release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code change looks good.

Related issues
Resolves STU-882
Proposed Changes
Testing Instructions
Pre-merge Checklist