Skip to content

Conversation

@ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Oct 24, 2025

Related issues

Resolves STU-882

Proposed Changes

  • add ARM64 app download nudge for users running Intel build under emulation on Windows
  • remove platform check from the logic (since we will now display the nudge on both macOS and Windows)
Markup on 2025-10-24 at 12:02:14

Testing Instructions

  1. Check out the PR branch, build and run the app on Windows.
  2. The nudge should render and work as expected.
  3. There should be no change for the nudge on macOS.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@ivan-ottinger ivan-ottinger self-assigned this Oct 24, 2025
@ivan-ottinger ivan-ottinger changed the title Add/download arm based app on windows nudge Add ARM64 app download nudge for users running Intel build under emulation on Windows Oct 24, 2025
@github-actions
Copy link

📊 Performance Test Results

Comparing e21bbc9 vs trunk

site-editor

Metric trunk e21bbc9 Diff Change
load 14966.00 ms 9701.00 ms -5265.00 ms 🟢 -35.2%

site-startup

Metric trunk e21bbc9 Diff Change
siteCreation 22253.00 ms 18159.00 ms -4094.00 ms 🟢 -18.4%
siteStartup 5993.00 ms 6984.00 ms +991.00 ms 🔴 16.5%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@ivan-ottinger ivan-ottinger marked this pull request as ready for review October 24, 2025 11:11
@ivan-ottinger ivan-ottinger requested a review from a team October 24, 2025 11:11
Copy link
Contributor

@bcotrim bcotrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I think we need to wait for #1916 to be merged, to test with both versions.

Meanwhile I confirmed the warning when running the x64 version on my Windows VM.

Image

One thing to consider:
Would it make sense to have the "Download" option automatically download and install the correct version? I believe that should be possible following a similar approach to what we do in the auto-updater.

) {
if ( appGlobals.arm64Translation && ! localStorage.getItem( 'dontShowARM64Warning' ) ) {
const showARM64MessageBox = async () => {
const platformMessages: Record< string, string > = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these need to match the option we have on the Studio site so it's to the user what they need to download. For macOS it looks good, for Windows is still unknown as far as I know.

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good catch. I will update the text in this PR once we agree on it.

@ivan-ottinger
Copy link
Contributor Author

Thank you for the review, Bernardo!

One thing to consider:
Would it make sense to have the "Download" option automatically download and install the correct version? I believe that should be possible following a similar approach to what we do in the auto-updater.

The auto-update process works with the currently running app architecture. I think it could be doable, but at the same time I suspect there could be potential issues if we try to run update from one app architecture to another. Maybe we could explore this once the ARM64 version is out.

I think we need to wait for #1916 to be merged, to test with both versions.

Yes, indeed. I think we can wait until the ARM64 version is launched and published on the site and merge this PR for the later Studio release.

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants