Ensure that all imported notes are sent to the server #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing over 350-400 notes at once can cause the syncing to get stuck. When the syncing is stuck, it can be resumed by calling
client.connect()
.How can we tell that syncing is stuck? We first need to be able to detect whether the syncing is active or idle. When syncing is idle despite there being unsynced notes left, we can tell that it is stuck. Then, we can resuscitate the transfer by calling
client.connect()
.This workaround adds a way to detect syncing activity (active/idle), by attaching debounced listeners to the simperium client's
send
andmessage
events. We can now hook arbitrary functions to these state changes. (This will probably come in handy when we add a syncing indicator in the future.)Also changed
debug
module for easier debugging (cc: @adlk)To test
localStorage.debug = 'sync:*'
.Here are some import files of various sizes: mock-simplenote-json.zip