-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SimplenoteImporter #975
Conversation
lib/utils/import/simplenote/index.js
Outdated
} | ||
|
||
// Limit file size we will read to 2mb | ||
if (file.size > 2000000) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a Simplenote export file with 1,600 notes that is just over 2mb. Maybe we should set a 5mb limit? Not sure if you tested it with a large export or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today I tested with export files of varying sizes (80KB – 4MB). While large files did not choke the app in terms of memory, it did degrade the experience in non-trivial ways:
- There is considerable lag between the point when all notes have been added to the noteBucket, and the point when the notes appear (all at once) in the Note List.
- Clicking on notes in the Note List is unresponsive for a while. The
onClick
is firing, but the redux dispatch is being deferred until a certain point... I'm not immediately sure what is causing this. - It takes quite a while for all the notes to be synced over to the server, and it is almost impossible to tell when it has finished. The only way to tell is to try clicking the Log Out button and see if it throws an unsynced notes warning.
- If there are lots of notes AND lots of tags, the tags take a long time to show up in the tag drawer.
With these constraints, I felt like a 500-note (~400KB) export file was as far as I wanted to go... 😵 And since these issues are occurring after the CoreImporter is done, I'm guessing the other importers will encounter them too.
I'll see if there are some easy things we can do to address at least 1 and 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It WFM 👍 |
This will need to be based on |
Will tweak later
103caa1
to
76dbbe3
Compare
Depends on #922
SimplenoteJSONImporter
? 🤔