Skip to content
This repository has been archived by the owner on Aug 27, 2018. It is now read-only.

Modify exports to make webpack es6 happy #184

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Modify exports to make webpack es6 happy #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "notifications-panel",
"version": "1.2.4",
"version": "1.2.5",
"description": "The core notifications panel for WordPress.com notifications",
"main": "src/Notifications.jsx",
"scripts": {
Expand Down
9 changes: 6 additions & 3 deletions src/comment-replies-cache/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,16 @@ function cleanupRepliesCache() {
});
}

var LocalStorageMixin = {
export const LocalStorageMixin = {
localStorage: {
getItem: getItem,
setItem: setItem,
removeItem: removeItem,
},
};
export const cleanup = cleanupRepliesCache;

module.exports.cleanup = cleanupRepliesCache;
module.exports.LocalStorageMixin = LocalStorageMixin;
export default {
cleanup,
LocalStorageMixin,
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason to export them individually and as a defaulted object?

Copy link
Contributor Author

@samouri samouri Oct 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its so that I don't need to chase down how the consumers are using it. Definitely not something that should be done during greenfield development