This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Modify exports to make webpack es6 happy #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
force-pushed
the
fix/imports-for-tree-shaking
branch
from
9ad62b5 to
0123c59
Compare
dmsnell
approved these changes
Oct 11, 2017
psealock
reviewed
Oct 15, 2017
| export default { | ||
| cleanup, | ||
| LocalStorageMixin, | ||
| }; |
There was a problem hiding this comment.
Whats the reason to export them individually and as a defaulted object?
There was a problem hiding this comment.
Its so that I don't need to chase down how the consumers are using it. Definitely not something that should be done during greenfield development
I didn't do an extensive test but I also don't think this change calls for it. I'll merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for use in Automattic/wp-calypso#16057 and potentially an eventual merge