Skip to content

Conversation

@thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Jul 28, 2022

All Submissions:

Changes proposed in this Pull Request:

This pattern simply adds an extra padding on larger screens to the group container via newspack-pattern registration__style-1

Note 1: This is for an upcoming pattern.
Note 2: There are some margin issues with the success message that I'll take care of in newspack-plugin merged: Automattic/newspack-plugin#1808

Screenshot 2022-07-28 at 11 56 57

Screenshot 2022-07-28 at 11 58 09

How to test the changes in this Pull Request:

  1. Add a reader registration block to a prompt
  2. Group the block and add custom classes: newspack-pattern registration__style-1
  3. Preview prompt and notice the extra padding added to the group block

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot requested a review from a team as a code owner July 28, 2022 10:59
@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 28, 2022
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 1, 2022
@thomasguillot thomasguillot merged commit 58f303d into master Aug 1, 2022
@thomasguillot thomasguillot deleted the add/newspack-pattern-registration-style-1 branch August 1, 2022 19:09
matticbot pushed a commit that referenced this pull request Aug 5, 2022
# [1.63.0-alpha.1](v1.62.0...v1.63.0-alpha.1) (2022-08-05)

### Bug Fixes

* **registration-block:** make sure font-family in the editor matches front-end ([#1889](#1889)) ([e0c4309](e0c4309))

### Features

* add custom style for upcoming registration pattern (style 1) ([#1888](#1888)) ([58f303d](58f303d))
* Add featured listing styles ([#1877](#1877)) ([efc4936](efc4936))
* colors' css variables and action hook for mobile toggle ([#1875](#1875)) ([0830ca7](0830ca7))
* redesign "My Account" page ([#1879](#1879)) ([9258f21](9258f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.63.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 16, 2022
# [1.63.0](v1.62.0...v1.63.0) (2022-08-16)

### Bug Fixes

* **registration-block:** make sure font-family in the editor matches front-end ([#1889](#1889)) ([e0c4309](e0c4309))
* use proper variable and escape function for primary color ([#1898](#1898)) ([1062b1a](1062b1a))

### Features

* add custom style for upcoming registration pattern (style 1) ([#1888](#1888)) ([58f303d](58f303d))
* Add featured listing styles ([#1877](#1877)) ([efc4936](efc4936))
* colors' css variables and action hook for mobile toggle ([#1875](#1875)) ([0830ca7](0830ca7))
* redesign "My Account" page ([#1879](#1879)) ([9258f21](9258f21))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.63.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants