-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add featured listing styles #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dkoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Oh, good catch @dkoo! I used I've added a pixel of wiggle room that seems to help! I also switched how the bottom "cut in" was measured -- it was originally a pixel value but got a little disproportionate at smaller font sizes. It now uses Just let me know if anything else seems funky to you! |
dkoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# [1.63.0-alpha.1](v1.62.0...v1.63.0-alpha.1) (2022-08-05) ### Bug Fixes * **registration-block:** make sure font-family in the editor matches front-end ([#1889](#1889)) ([e0c4309](e0c4309)) ### Features * add custom style for upcoming registration pattern (style 1) ([#1888](#1888)) ([58f303d](58f303d)) * Add featured listing styles ([#1877](#1877)) ([efc4936](efc4936)) * colors' css variables and action hook for mobile toggle ([#1875](#1875)) ([0830ca7](0830ca7)) * redesign "My Account" page ([#1879](#1879)) ([9258f21](9258f21))
|
🎉 This PR is included in version 1.63.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.63.0](v1.62.0...v1.63.0) (2022-08-16) ### Bug Fixes * **registration-block:** make sure font-family in the editor matches front-end ([#1889](#1889)) ([e0c4309](e0c4309)) * use proper variable and escape function for primary color ([#1898](#1898)) ([1062b1a](1062b1a)) ### Features * add custom style for upcoming registration pattern (style 1) ([#1888](#1888)) ([58f303d](58f303d)) * Add featured listing styles ([#1877](#1877)) ([efc4936](efc4936)) * colors' css variables and action hook for mobile toggle ([#1875](#1875)) ([0830ca7](0830ca7)) * redesign "My Account" page ([#1879](#1879)) ([9258f21](9258f21))
|
🎉 This PR is included in version 1.63.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |


All Submissions:
Changes proposed in this Pull Request:
This PR contains a first swing at the featured listing styles for the Newspack theme.
I think it made sense to tackle them in the theme rather than the plugin because the styles might differ from theme to theme, and that the styles are applied to blocks in two different plugins (Newspack Blocks, Newspack Listings), on top of the archive and search styles in the theme. Happy to discuss that further if moving them makes sense though!
See Automattic/newspack-listings#131.
How to test the changes in this Pull Request:
define( 'NEWSPACK_LISTINGS_FEATURED_ENABLED', true );to your wp-config.php file.Homepage Posts block:
Post Carousel:
Curated List (note: the featured image classes are not yet added to the curated list block in the editor; issue filed here).
Other information: