fix: tweak inline gate styles for block theme#4445
Open
laurelfulford wants to merge 3 commits intotrunkfrom
Open
fix: tweak inline gate styles for block theme#4445laurelfulford wants to merge 3 commits intotrunkfrom
laurelfulford wants to merge 3 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the inline Content Gate's styling to properly respect block widths in the block theme, ensuring gates display correctly across different layout templates.
Changes:
- Added CSS styling to constrain inline gate maximum width
- Updated inline gate wrapper to include block layout class
- Added max-width constraint to fade overlay element
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/content-gate/gate.scss | Adds max-width constraint to inline gate container |
| includes/content-gate/trait-content-gate-layout.php | Applies layout-constrained class and max-width to gate wrapper and fade overlay |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR makes some tweaks to the inline Content Gate so it respects block widths.
It needs to be tested with the Classic Theme with this PR: Automattic/newspack-theme#2625
And it needs to be tested with the Block theme with this PR: Automattic/newspack-block-theme#407
Closes NPPD-1180
How to test the changes in this Pull Request:
Other information: