Skip to content

Conversation

@laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR fixes a possible issue with very common custom CSS.

See 1207817176293825-as-1208873548407902

How to test the changes in this Pull Request:

  1. Add this CSS to the Customizer - it's a pretty common style of snippet that we use to increases/decrease content font sizes:
.entry-content p, 
.entry-content li {
    font-size: 1.1rem;
}
  1. In an incognito window, go to My Account, and log in to an existing RAS account.
  2. Note the appearance of the OPT message:

CleanShot 2024-11-29 at 11 37 54

  1. Apply this PR and run npm run build.
  2. Confirm that the message is now sized correctly:

CleanShot 2024-11-29 at 11 38 50

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner November 29, 2024 19:39
@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed ras-acc testing labels Nov 29, 2024
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 2, 2024
@laurelfulford laurelfulford merged commit 080f1ce into trunk Dec 2, 2024
@laurelfulford laurelfulford deleted the fix/my-account-font-sizing branch December 2, 2024 20:48
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Dec 2, 2024
# [5.9.0-alpha.2](v5.9.0-alpha.1...v5.9.0-alpha.2) (2024-12-02)

### Bug Fixes

* **emails:** account for false order value ([#3590](#3590)) ([a2e4042](a2e4042))
* **ras-acc:** correct My Account custom font sizing clash ([#3588](#3588)) ([080f1ce](080f1ce))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.9.0-alpha.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 9, 2024
# [5.9.0](v5.8.2...v5.9.0) (2024-12-09)

### Bug Fixes

* **emails:** account for false order value ([#3590](#3590)) ([a2e4042](a2e4042))
* **ras-acc:** correct My Account custom font sizing clash ([#3588](#3588)) ([080f1ce](080f1ce))
* **ras-acc:** make helper text size more specific ([#3584](#3584)) ([5bcc688](5bcc688))
* **ras-acc:** re-add recaptcha to the WooCommerce checkout ([#3605](#3605)) ([07f46b3](07f46b3))
* undefined var ([#3585](#3585)) ([00d8bc7](00d8bc7))
* **woocommerce-emails:** use the default email payload if there are no donation products ([#3545](#3545)) ([60c21f3](60c21f3))

### Features

* mark perfmatters as a required plugin ([#3578](#3578)) ([f20291c](f20291c))
* **ras-acc:** add reader account creation and login improvements ([#3582](#3582)) ([b66de08](b66de08))
* **reader-data:** add a CLI command to align reader membership data ([#3548](#3548)) ([8e49bf0](8e49bf0))
* **subscriptions:** add setting to reattempt payment after final retry ([#3560](#3560)) ([553c3ac](553c3ac))
* **woocommerce:** remove internal metadata from REST API response ([6b659a6](6b659a6))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ras-acc testing released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants