Skip to content

fix(ras-acc): make helper text size more specific #3584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laurelfulford merged 1 commit into from
Nov 29, 2024
Merged

fix(ras-acc): make helper text size more specific #3584

laurelfulford merged 1 commit into from
Nov 29, 2024

Conversation

@laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Nov 28, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR fixes the font size used for the NYP text and coupon error message in RAS-ACC -- the styles were inheriting incorrectly.

See 1207817176293825-as-1208868035568741

How to test the changes in this Pull Request:

  1. Enable coupons under WooCommerce > Settings, and create one under WooCommerce > Marketing > Coupons.
  2. Create a NYP product.
  3. Add a checkout button block to a page, and assign it the NYP product.
  4. Run through a checkout; on the second screen, note the size of the NYP instructions. To test the coupon text, enter some random text and hit 'Apply'. The text for both is 16px when it should be 14px:

CleanShot 2024-11-28 at 14 03 40@2x

  1. Apply this PR and run npm run build.
  2. Confirm that the font size for both is now 14px:

CleanShot 2024-11-28 at 14 05 19

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added [Status] Needs Review The issue or pull request needs to be reviewed ras-acc testing labels Nov 28, 2024
@laurelfulford laurelfulford requested a review from a team as a code owner November 28, 2024 22:05
@laurelfulford laurelfulford merged commit 5bcc688 into trunk Nov 29, 2024
@laurelfulford laurelfulford deleted the fix/ras-acc-helper-text branch November 29, 2024 16:24
@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 29, 2024
matticbot pushed a commit that referenced this pull request Nov 29, 2024
@semantic-release-bot
chore(release): 5.9.0-alpha.1 [skip ci]
3f31c2e 
# [5.9.0-alpha.1](v5.8.1...v5.9.0-alpha.1) (2024-11-29)

### Bug Fixes

* **ras-acc:** make helper text size more specific ([#3584](#3584)) ([5bcc688](5bcc688))
* undefined var ([#3585](#3585)) ([00d8bc7](00d8bc7))
* **woocommerce-emails:** use the default email payload if there are no donation products ([#3545](#3545)) ([60c21f3](60c21f3))

### Features

* mark perfmatters as a required plugin ([#3578](#3578)) ([f20291c](f20291c))
* **ras-acc:** add reader account creation and login improvements ([#3582](#3582)) ([b66de08](b66de08))
* **reader-data:** add a CLI command to align reader membership data ([#3548](#3548)) ([8e49bf0](8e49bf0))
* **subscriptions:** add setting to reattempt payment after final retry ([#3560](#3560)) ([553c3ac](553c3ac))
* **woocommerce:** remove internal metadata from REST API response ([6b659a6](6b659a6))
@matticbot
Copy link
Contributor

matticbot commented Nov 29, 2024

🎉 This PR is included in version 5.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 9, 2024
@semantic-release-bot
chore(release): 5.9.0 [skip ci]
460e716 
# [5.9.0](v5.8.2...v5.9.0) (2024-12-09)

### Bug Fixes

* **emails:** account for false order value ([#3590](#3590)) ([a2e4042](a2e4042))
* **ras-acc:** correct My Account custom font sizing clash ([#3588](#3588)) ([080f1ce](080f1ce))
* **ras-acc:** make helper text size more specific ([#3584](#3584)) ([5bcc688](5bcc688))
* **ras-acc:** re-add recaptcha to the WooCommerce checkout ([#3605](#3605)) ([07f46b3](07f46b3))
* undefined var ([#3585](#3585)) ([00d8bc7](00d8bc7))
* **woocommerce-emails:** use the default email payload if there are no donation products ([#3545](#3545)) ([60c21f3](60c21f3))

### Features

* mark perfmatters as a required plugin ([#3578](#3578)) ([f20291c](f20291c))
* **ras-acc:** add reader account creation and login improvements ([#3582](#3582)) ([b66de08](b66de08))
* **reader-data:** add a CLI command to align reader membership data ([#3548](#3548)) ([8e49bf0](8e49bf0))
* **subscriptions:** add setting to reattempt payment after final retry ([#3560](#3560)) ([553c3ac](553c3ac))
* **woocommerce:** remove internal metadata from REST API response ([6b659a6](6b659a6))
@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

🎉 This PR is included in version 5.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leogermani leogermani leogermani approved these changes

Assignees

No one assigned

Labels

ras-acc testing released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laurelfulford @matticbot @leogermani