fix(ras): destroy sessions on account verification #3328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
added
the
[Status] Needs Review
leogermani
approved these changes
Aug 12, 2024
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Aug 15, 2024
# [5.1.0-alpha.1](v5.0.1...v5.1.0-alpha.1) (2024-08-15) ### Bug Fixes * **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194)) * **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb)) ### Features * add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c)) * add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
Contributor
|
🎉 This PR is included in version 5.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 5.3.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 5.3.0-hotfix-memberships-prop-exists.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [5.3.0](v5.2.1...v5.3.0) (2024-08-26) ### Bug Fixes * **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194)) * **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb)) ### Features * add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c)) * add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
Contributor
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
p1722617670146119-slack-C015W6BES8J
Replaces the strategy implemented in #1787.
Upon verification, we want to destroy existing sessions to prevent a bad actor having originated the account creation from accessing the, now verified, account. If the verification is for the current user, we destroy other sessions.
How to test the changes in this Pull Request:
\Newspack\Reader_Activation::set_reader_verified( $user_id );Other information: