-
Notifications
You must be signed in to change notification settings - Fork 59
fix(data-events): gate interaction for registration form #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-events): gate interaction for registration form #3327
Conversation
leogermani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well
# [5.1.0-alpha.1](v5.0.1...v5.1.0-alpha.1) (2024-08-15) ### Bug Fixes * **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194)) * **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb)) ### Features * add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c)) * add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
|
🎉 This PR is included in version 5.1.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.3.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.3.0-hotfix-memberships-prop-exists.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [5.3.0](v5.2.1...v5.3.0) (2024-08-26) ### Bug Fixes * **data-events:** gate interaction for registration form ([#3327](#3327)) ([eb06194](eb06194)) * **ras:** destroy sessions on account verification ([#3328](#3328)) ([ab6efeb](ab6efeb)) ### Features * add phpcs sniff for newsletter methods ([#3337](#3337)) ([15f237c](15f237c)) * add woo team sync metadata (WIP) ([#3325](#3325)) ([e5cc5e3](e5cc5e3))
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
1200550061930446-as-1207615072285532
#2740 introduced tracking capabilities for forms inside the gate, which covers the Reader Registration Block and Checkout Button Block.
There's the unhandled case of registrations initiated via a hash link on the gate, which triggers the RAS' global auth form:
To handle those cases, this PR proposes that the tracking input be added to RAS' auth form when visiting gated content.
This means registrations made on gated content, but initiated outside of the gate (like the header "Sign In" button), will also be treated as a gate interaction. To improve accuracy, the tracking input should now only be added once the gate is seen on the page. With that strategy, once the page loads the reader may register through the header "Sign In" and never realize that they are on gated content, which will not be a gate interaction. Once they scroll down and hit the gate, they may scroll back up, register from "Sign In", and it will be a gate interaction.
How to test the changes in this Pull Request:
registration_methodmetadata asauth-formregistration_methodmetadata asregistration-block-content-gate{"name":"np_gate_interaction","action":"form_submission_received","action_type":"registration"}{"name":"np_gate_interaction","action":"form_submission_success","action_type":"registration"}Other information: