fix(modal-checkout): align Stripe's "save payment" checkbox #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasguillot
approved these changes
Dec 7, 2023
Contributor
thomasguillot
left a comment
thomasguillot
left a comment
There was a problem hiding this comment.
Nice, thank you @miguelpeixe!
matticbot
pushed a commit
that referenced
this pull request
Dec 7, 2023
# [2.3.0-alpha.5](v2.3.0-alpha.4...v2.3.0-alpha.5) (2023-12-07) ### Bug Fixes * **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42))
Contributor
|
🎉 This PR is included in version 2.3.0-alpha.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 7, 2023
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2023-12-07) ### Bug Fixes * modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db)) * **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42)) * **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd)) * replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0)) ### Features * improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190)) * **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1)) ### Performance Improvements * **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
Contributor
|
🎉 This PR is included in version 2.4.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Dec 11, 2023
# [2.4.0](v2.3.0...v2.4.0) (2023-12-11) ### Bug Fixes * modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db)) * **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42)) * **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd)) * replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0)) ### Features * improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190)) * **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1)) ### Performance Improvements * **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
Contributor
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Tweaks the alignment of the "Save payment information to my account for future purchases." checkbox.
How to test the changes in this Pull Request:
Checkout this branch, go through the modal checkout flow, and confirm the checkbox is not misaligned.
Other information: