-
Notifications
You must be signed in to change notification settings - Fork 44
perf(modal-checkout): process checkout request earlier #1612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adekbadek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 👌
# [2.3.0-alpha.1](v2.2.2...v2.3.0-alpha.1) (2023-11-30) ### Bug Fixes * modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db)) * **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd)) ### Features * improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190)) * **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1)) ### Performance Improvements * **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
|
🎉 This PR is included in version 2.3.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2023-12-07) ### Bug Fixes * modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db)) * **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42)) * **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd)) * replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0)) ### Features * improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190)) * **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1)) ### Performance Improvements * **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
|
🎉 This PR is included in version 2.4.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [2.4.0](v2.3.0...v2.4.0) (2023-12-11) ### Bug Fixes * modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db)) * **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42)) * **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd)) * replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0)) ### Features * improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190)) * **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1)) ### Performance Improvements * **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Process the checkout request in an earlier hook for improved performance. Also added a guard clause to bail on
is_admin()sincewp_loadedis a higher scope hook executed on every load.How to test the changes in this Pull Request:
Other information: