Skip to content

Conversation

@miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Nov 28, 2023

All Submissions:

Changes proposed in this Pull Request:

Process the checkout request in an earlier hook for improved performance. Also added a guard clause to bail on is_admin() since wp_loaded is a higher scope hook executed on every load.

How to test the changes in this Pull Request:

  1. Checkout this branch and go through the modal checkout flow from a Checkout Button block
  2. Confirm you are able to purchase without issues

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe requested a review from a team as a code owner November 28, 2023 15:47
@miguelpeixe miguelpeixe self-assigned this Nov 28, 2023
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👌

@miguelpeixe miguelpeixe merged commit 5c58f5e into master Nov 29, 2023
@miguelpeixe miguelpeixe deleted the perf/process-checkout-hook branch November 29, 2023 12:17
matticbot pushed a commit that referenced this pull request Nov 30, 2023
# [2.3.0-alpha.1](v2.2.2...v2.3.0-alpha.1) (2023-11-30)

### Bug Fixes

* modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db))
* **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd))

### Features

* improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190))
* **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1))

### Performance Improvements

* **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.3.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 7, 2023
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2023-12-07)

### Bug Fixes

* modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db))
* **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42))
* **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd))
* replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0))

### Features

* improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190))
* **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1))

### Performance Improvements

* **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 11, 2023
# [2.4.0](v2.3.0...v2.4.0) (2023-12-11)

### Bug Fixes

* modal checkout template markup ([#1608](#1608)) ([4d593db](4d593db))
* **modal-checkout:** align Stripe's "save payment" checkbox ([#1623](#1623)) ([69e0e42](69e0e42))
* **modal-checkout:** prevent initial render of details table ([#1601](#1601)) ([06d4ccd](06d4ccd))
* replace FILTER_SANITIZE_STRING ([6f805b0](6f805b0))

### Features

* improve performance of modal checkout ([#1607](#1607)) ([a48d190](a48d190))
* **modal-checkout:** add filter to cart item data ([#1590](#1590)) ([1e83dc1](1e83dc1))

### Performance Improvements

* **modal-checkout:** process checkout request earlier ([#1612](#1612)) ([5c58f5e](5c58f5e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants