Update DataViews dependency to v12 with wp-theme#46973
Update DataViews dependency to v12 with wp-theme#46973
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Still looking but I think you need something like: JSimport '@wordpress/theme/design-tokens.css';Or use SCSS@use '@wordpress/theme/design-tokens.css';or @import '@wordpress/theme/design-tokens.css'; |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
96d255e to
6051a1f
Compare
The new DataViews version no longer bundles @wordpress/theme/design-tokens.css.
Import it explicitly to provide CSS variables needed by DataForm components.
6051a1f to
72f88f3
Compare
| peerDependencies: | ||
| ajv: ^8.8.2 | ||
|
|
||
| ajv@6.12.6: |
There was a problem hiding this comment.
A pnpm dedupe run would be good to clean up some of the extra package versions being added here. For this one in particular, it'd be good to not re-open https://github.com/Automattic/jetpack/security/dependabot/413 🙂
Updates DataViews to
v12release, and makes changes to accommodate for the breaking change.Changelog
Previous stable release for reference #46853
Proposed changes:
See changelog:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: