Skip to content

Update DataViews dependency to v12 with wp-theme#46973

Draft
simison wants to merge 9 commits intotrunkfrom
update/dataviews-next-with-theme
Draft

Update DataViews dependency to v12 with wp-theme#46973
simison wants to merge 9 commits intotrunkfrom
update/dataviews-next-with-theme

Conversation

@simison
Copy link
Member

@simison simison commented Feb 5, 2026

Updates DataViews to v12 release, and makes changes to accommodate for the breaking change.

Changelog

Previous stable release for reference #46853

Proposed changes:

  • Update DataViews
  • Include Theme package where I think we should update it
  • Doesn't include Theme package in unreleased UIs; those will break visually, but seems fine now.

See changelog:

The design tokens stylesheet (@wordpress/theme/design-tokens.css) is no longer embedded in the DataViews stylesheet. Applications using DataViews outside of WordPress must now explicitly include the design tokens stylesheet. See the README for installation instructions. WordPress/gutenberg#75182

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Test DataViews UIs in affected packages.

@simison simison changed the title Update/dataviews next with theme Update DataViews dependency to @next with wp-theme Feb 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/dataviews-next-with-theme branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/dataviews-next-with-theme
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/dataviews-next-with-theme

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@simison simison requested review from a team and dsas February 5, 2026 14:44
@simison
Copy link
Member Author

simison commented Feb 5, 2026

Still looking but I think you need something like:

JS

import '@wordpress/theme/design-tokens.css';

Or use <ThemeProvider>, but that seems to still be a locked API.

SCSS

@use '@wordpress/theme/design-tokens.css';

or

@import '@wordpress/theme/design-tokens.css';

@jp-launch-control
Copy link

jp-launch-control bot commented Feb 5, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison force-pushed the update/dataviews-next-with-theme branch 2 times, most recently from 96d255e to 6051a1f Compare February 11, 2026 18:51
@simison simison changed the title Update DataViews dependency to @next with wp-theme Update DataViews dependency to v12 with wp-theme Feb 24, 2026
simison and others added 3 commits February 24, 2026 09:55
      The new DataViews version no longer bundles @wordpress/theme/design-tokens.css.
      Import it explicitly to provide CSS variables needed by DataForm components.
@simison simison force-pushed the update/dataviews-next-with-theme branch from 6051a1f to 72f88f3 Compare February 24, 2026 08:07
peerDependencies:
ajv: ^8.8.2

ajv@6.12.6:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pnpm dedupe run would be good to clean up some of the extra package versions being added here. For this one in particular, it'd be good to not re-open https://github.com/Automattic/jetpack/security/dependabot/413 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants