Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
slack_token: ${{ secrets.SLACK_TOKEN }}
slack_channel: ${{ secrets.SLACK_E2E_CHANNEL }}
slack_channel: ${{ vars.SLACK_E2E_CHANNEL }}
slack_icon_emoji: ":jetpack:"
suite_name: ${{ env.NOTIFICATION_SUITE }}
playwright_report_path: test-output/**/summary.json
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/gardening.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
slack_token: ${{ secrets.SLACK_TOKEN }}
slack_team_channel: ${{ secrets.SLACK_TEAM_CHANNEL }}
slack_design_channel: ${{ secrets.SLACK_DESIGN_CHANNEL }}
slack_editorial_channel: ${{ secrets.SLACK_EDITORIAL_CHANNEL }}
slack_he_triage_channel: ${{ secrets.SLACK_HE_TRIAGE_CHANNEL }}
slack_quality_channel: ${{ secrets.SLACK_QUALITY_CHANNEL }}
slack_team_channel: ${{ vars.SLACK_TEAM_CHANNEL }}
slack_design_channel: ${{ vars.SLACK_DESIGN_CHANNEL }}
slack_editorial_channel: ${{ vars.SLACK_EDITORIAL_CHANNEL }}
slack_he_triage_channel: ${{ vars.SLACK_HE_TRIAGE_CHANNEL }}
slack_quality_channel: ${{ vars.SLACK_QUALITY_CHANNEL }}
triage_projects_token: ${{ secrets.PROJECT_AUTOMATION_TOKEN }}
project_board_url: ${{ secrets.PROJECT_BOARD_URL }}
project_board_url: ${{ vars.PROJECT_BOARD_URL }}
openai_api_key: ${{ secrets.OPENAI_API_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/slack-branch-existence-notification.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Generate message
id: message
env:
SLACK_RELEASES_CHANNEL: ${{ secrets.SLACK_RELEASES_CHANNEL }}
SLACK_RELEASES_CHANNEL: ${{ vars.SLACK_RELEASES_CHANNEL }}
run: |
source .github/files/gh-funcs.sh

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/slack-workflow-failed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:
- name: Generate message
id: message
env:
SLACK_JP_ALERTS_CHANNEL: ${{ secrets.SLACK_JP_ALERTS_CHANNEL }}
SLACK_RELEASES_CHANNEL: ${{ secrets.SLACK_RELEASES_CHANNEL }}
SLACK_JP_ALERTS_CHANNEL: ${{ vars.SLACK_JP_ALERTS_CHANNEL }}
SLACK_RELEASES_CHANNEL: ${{ vars.SLACK_RELEASES_CHANNEL }}
run: |
source .github/files/gh-funcs.sh

Expand Down
12 changes: 6 additions & 6 deletions projects/github-actions/repo-gardening/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
slack_token: ${{ secrets.SLACK_TOKEN }}
slack_design_channel: ${{ secrets.SLACK_DESIGN_CHANNEL }}
slack_design_channel: ${{ vars.SLACK_DESIGN_CHANNEL }}
tasks: 'cleanLabels,notifyDesign'
```

Expand All @@ -76,11 +76,11 @@ The action relies on the following parameters.
- (Optional) `tasks` allows for running selected tasks instead of the full suite. The value is a comma-separated list of task identifiers. You can find the list of the different tasks (and what event it's attached to) in `src/index.js`.
- (Optional) `add_labels`. Pass custom labels to add. Defaults to an empty string. Only applies for the [addLabel](src/tasks/add-labels/readme.md) task.
- (Optional) `slack_token` is the Auth token of a bot that is installed on your Slack workspace. The token should be stored in a [secret](https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository). See the instructions below to create a bot.
- (Optional) `slack_design_channel` is the Slack public channel ID where messages for the design team will be posted. Again, the value should be stored in a secret.
- (Optional) `slack_editorial_channel` is the Slack public channel ID where messages for the Editorial team will be posted. Again, the value should be stored in a secret.
- (Optional) `slack_team_channel` is the Slack public channel ID where general notifications about your repo should be posted. Again, the value should be stored in a secret.
- (Optional) `slack_he_triage_channel` is the Slack public channel ID where messages for the HE Triage team will be posted. The value should be stored in a secret.
- (Optional) `slack_quality_channel` is the Slack public channel ID where issues needing extra triage / escalation will be sent. The value should be stored in a secret.
- (Optional) `slack_design_channel` is the Slack public channel ID where messages for the design team will be posted. The channel ID should be stored in an Actions [variable](https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/use-variables).
- (Optional) `slack_editorial_channel` is the Slack public channel ID where messages for the Editorial team will be posted. Again, the value should be stored in a variable.
- (Optional) `slack_team_channel` is the Slack public channel ID where general notifications about your repo should be posted. Again, the value should be stored in a variable.
- (Optional) `slack_he_triage_channel` is the Slack public channel ID where messages for the HE Triage team will be posted. The value should be stored in a variable.
- (Optional) `slack_quality_channel` is the Slack public channel ID where issues needing extra triage / escalation will be sent. The value should be stored in a variable.
- (Optional) `reply_to_customers_threshold`. It is optional, and defaults to 10. It is the minimum number of support references needed to trigger an alert that we need to reply to customers.
- (Optional) `triage_projects_token` is a [personal access token](https://github.com/settings/tokens/new) with `repo` and `project` scopes. The token should be stored in a secret. This is required if you want to use the `triageIssues` task.
- (Optional) `project_board_url` is the URL of a GitHub Project Board. We'll automate some of the work on that board in the `triageIssues` task.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Update README to recommend vars instead of secrets where appropriate.
Loading