Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Dec 18, 2025

Closes MONOREP-300

Proposed changes:

We don't need the project board URL or various Slack channel IDs to be secret. They're just identifiers, and not even ones where security-through-obscurity might be beneficial.

Pairs like ID/key are left as secrets, even if the ID isn't really secret, because it's clearer to keep those together than to split them across two different lists.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1764014167264399-slack-C05Q5HSS013

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We don't need the project board URL or various Slack channel IDs to be
secret. They're just identifiers, and not even ones where
security-through-obscurity might be beneficial.

Pairs like ID/key are left as secrets, even if the ID isn't really
secret, because it's clearer to keep those together than to split them
across two different lists.
@anomiex anomiex requested a review from a team December 18, 2025 19:21
@anomiex anomiex self-assigned this Dec 18, 2025
@anomiex anomiex requested a review from jeherve as a code owner December 18, 2025 19:21
@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management Docs labels Dec 18, 2025
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management Docs [Pri] Normal [Status] Needs Review This PR is ready for review. [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants