Skip to content

Conversation

enejb
Copy link
Member

@enejb enejb commented Sep 30, 2019

Some themes or plugins don't correctly apply admin body classes. Such as the inVough theme.
This PR fixes it by updating the priority of classes to be applied after the themes classes get applied.

Before:
Screen Shot 2019-09-30 at 1 07 35 PM

After:
Screen Shot 2019-09-30 at 1 07 16 PM

Changes proposed in this Pull Request:

  • increments the priority of when the admin classes get applied so that they still get displayed even though some other plugin could be ignoring them.

Testing instructions:

Install the inVough theme https://wordpress.org/themes/invogue/

  • Go to Jetpack Dashboard notice that the page looks as expected.

Proposed changelog entry for your changes:

  • Minor fixes for improving the display of the jetpack admin pages.

@enejb enejb added the [Status] Needs Review This PR is ready for review. label Sep 30, 2019
@enejb enejb requested review from a team September 30, 2019 11:17
@enejb enejb self-assigned this Sep 30, 2019
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against 29c138f

@jeherve jeherve added this to the 7.9 milestone Sep 30, 2019
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Sep 30, 2019
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nicely done 🚢

@enejb enejb merged commit c470dcb into master Sep 30, 2019
@enejb enejb deleted the update/fix-admin-classes branch September 30, 2019 13:14
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Sep 30, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
jeherve added a commit that referenced this pull request Oct 29, 2019
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants