Skip to content

Conversation

joanrho
Copy link
Contributor

@joanrho joanrho commented Sep 27, 2019

Updates external link gridicons for the security scan and downtime monitoring notification settings from "chevron-right" to "external" (they all link to destinations outside of wp-admin).

Fixes #13569

Before/After screenshots:

Screen Shot 2019-09-27 at 3 46 27 PM

Testing instructions:

  • Check out this branch
  • Run yarn build
  • Visit the Jetpack Settings in wp-admin on your Jetpack Sandbox site or whatever site you're testing on
  • Ensure the changes reflect the above "After" mockup as shown above

Proposed changelog entry:

  • Update security settings external link gridicons

@joanrho joanrho added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu labels Sep 27, 2019
@joanrho joanrho requested a review from a team September 27, 2019 21:51
@joanrho joanrho self-assigned this Sep 27, 2019
@jetpackbot
Copy link
Collaborator

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f533cb6

@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 30, 2019
@jeherve jeherve added this to the 7.9 milestone Sep 30, 2019
@zinigor zinigor merged commit 5556ae5 into master Sep 30, 2019
@zinigor zinigor deleted the update/security-settings-gridicons branch September 30, 2019 12:43
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 30, 2019
jeherve added a commit that referenced this pull request Oct 23, 2019
jeherve added a commit that referenced this pull request Oct 29, 2019
* 7.9: Changelog

* Update version number

* Update stable tag and tested up to

* Changelog: add #13530

* changelog: add #13578

* Changelog: add #13598

* Changelog: add entry for numerous block preview changes

* Changelog: add #13599

* changelog: add #13541

* Changelog: add #13542

* Changelog: add #13331

* Changelog: add #13558

* Changelog: add #13409

* Changelog: add #13582

* Changelog: add #13600

* Changelog: add #13601

* Changelog: add #13595

* Changelog: add #12695

* Changelog: add #13009

* Changelog: add #13649

* Changelog: add #13450

* Changelog: add #13507

* Changelog: add #13658

* Changelog: add #13687

* changelog: add #13683

* Changelog: add #9323

* Changelog: add #13681

* Fix typos in readme

* Add link to WordPress Beta Tester plugin

* Changelog: add #13630

* Changelog: add #13695

* Changelog: add #13659

* Changelog: add #13716

* Changelog: add #13664

* Changelog: add #13682

* Changelog: add #13362

* Changelog: add #13563

* Add testing list for #13563

* Changelog: add #13735

* Changelog: add #13752

* Changelog: add #13624

* Changelog: add #13756

* Changelog: add #13745

* Changelog: add #13728

* Changelog: add #13779

* Changelog: add #13699

* Changelog: add #13804

* Changelog: add #13761

* Changelog: add #13637

* Changelog: add #13517

* Changelog: add #13521

* Changelog: add #13729

* Testing list: add testing instructions for #13729

* Changelog: add sync changes

* Changelog: add #13807

* Changelog: add #13654

* Changelog: add #13795

* Changelog: add #13801

* Changelog: add #13818

* Changelog: add #13725

* Changelog: add #13831

* Changelog: add #13516

* Testing list: add Twenty Twenty instructions

* Changelog: add #13799

* Changelog: add #13805

* Changelog: add #13688

* Changelog: add #13830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent icons for external links
5 participants