Skip to content

feat(core): add a ton of rules from the backlog #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 4, 2025
Merged

Conversation

elijah-potter
Copy link
Collaborator

@elijah-potter elijah-potter commented Feb 27, 2025

Issues

#777, #790, #815, #800, #472, #820, #822

Description

I'm going through our issue backlog looking for corrections that fit well within the phrase_corrections category. This will have a lot of small fixes to that file.

How Has This Been Tested?

I will be adding unit tests from the issue descriptions.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@elijah-potter elijah-potter self-assigned this Feb 27, 2025
@elijah-potter elijah-potter changed the title feat(core): add rule for #777 feat(core): add a ton of rules from backlog Feb 27, 2025
@elijah-potter elijah-potter changed the title feat(core): add a ton of rules from backlog feat(core): add a ton of rules from the backlog Feb 27, 2025
@elijah-potter elijah-potter marked this pull request as ready for review February 27, 2025 19:17
@elijah-potter elijah-potter merged commit 904853a into master Mar 4, 2025
17 checks passed
@elijah-potter elijah-potter deleted the many-phrases branch March 4, 2025 17:55
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.23.0` -> `v0.24.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.24.0`](https://github.com/Automattic/harper/releases/tag/v0.24.0)

[Compare Source](Automattic/harper@v0.23.0...v0.24.0)

#### What's Changed

-   feat(core): add five technical words to the curated dictionary by [@&#8203;86xsk](https://github.com/86xsk) in Automattic/harper#767
-   Rid off phrase corrections by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#717
-   chore: new words and fixes to existing entries by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#783
-   fix(core): don't ignore blocking word-likes by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#788
-   fix(core): remove bad `Forthwith` rule by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#787
-   fix(core): address edge-case from [#&#8203;744](Automattic/harper#744) by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#786
-   feat: implement false positive "the great might of" by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#795
-   chore: add words and improve affix annotations by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#793
-   test: check that dictionary attributes can be spread over two entries by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#779
-   test(core): issue [#&#8203;798](Automattic/harper#798) by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#799
-   chore: add words, fix annotations by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#805
-   feat(web): create page for debugging the title-case algo by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#801
-   chore: curate dictionary by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#803
-   build(deps-dev): bump [@&#8203;types/jasmine](https://github.com/types/jasmine) from 5.1.6 to 5.1.7 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#810
-   build(deps-dev): bump rollup from 4.34.6 to 4.34.9 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#808
-   build(deps): bump clap from 4.5.29 to 4.5.31 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#814
-   build(deps-dev): bump prettier from 3.5.2 to 3.5.3 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#811
-   build(deps): bump serde_json from 1.0.138 to 1.0.139 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#813
-   feat(core): add a ton of rules from the backlog by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#797
-   WordPress plugin by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#817
-   Dictionary curation 2025 03 04 by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#819
-   build(deps-dev): bump [@&#8203;types/node](https://github.com/types/node) from 22.13.4 to 22.13.9 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#818
-   test(core): added test with capital letters by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#738
-   build(deps): bump pulldown-cmark from 0.12.2 to 0.13.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#693
-   refactor(core): proper noun linters use canonical casing and JSON file by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#834
-   Dictionary curation 2025 03 05 by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#833
-   feat: lex 0s 1s 0's 1's etc as words by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#775
-   refactor: nominal and determiner word types by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#731

#### New Contributors

-   [@&#8203;86xsk](https://github.com/86xsk) made their first contribution in Automattic/harper#767

**Full Changelog**: Automattic/harper@v0.23.0...v0.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 6, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.23.0` -> `v0.24.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.24.0`](https://github.com/Automattic/harper/releases/tag/v0.24.0)

[Compare Source](Automattic/harper@v0.23.0...v0.24.0)

#### What's Changed

-   feat(core): add five technical words to the curated dictionary by [@&#8203;86xsk](https://github.com/86xsk) in Automattic/harper#767
-   Rid off phrase corrections by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#717
-   chore: new words and fixes to existing entries by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#783
-   fix(core): don't ignore blocking word-likes by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#788
-   fix(core): remove bad `Forthwith` rule by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#787
-   fix(core): address edge-case from [#&#8203;744](Automattic/harper#744) by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#786
-   feat: implement false positive "the great might of" by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#795
-   chore: add words and improve affix annotations by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#793
-   test: check that dictionary attributes can be spread over two entries by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#779
-   test(core): issue [#&#8203;798](Automattic/harper#798) by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#799
-   chore: add words, fix annotations by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#805
-   feat(web): create page for debugging the title-case algo by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#801
-   chore: curate dictionary by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#803
-   build(deps-dev): bump [@&#8203;types/jasmine](https://github.com/types/jasmine) from 5.1.6 to 5.1.7 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#810
-   build(deps-dev): bump rollup from 4.34.6 to 4.34.9 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#808
-   build(deps): bump clap from 4.5.29 to 4.5.31 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#814
-   build(deps-dev): bump prettier from 3.5.2 to 3.5.3 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#811
-   build(deps): bump serde_json from 1.0.138 to 1.0.139 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#813
-   feat(core): add a ton of rules from the backlog by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#797
-   WordPress plugin by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#817
-   Dictionary curation 2025 03 04 by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#819
-   build(deps-dev): bump [@&#8203;types/node](https://github.com/types/node) from 22.13.4 to 22.13.9 in /packages by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#818
-   test(core): added test with capital letters by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#738
-   build(deps): bump pulldown-cmark from 0.12.2 to 0.13.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#693
-   refactor(core): proper noun linters use canonical casing and JSON file by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#834
-   Dictionary curation 2025 03 05 by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#833
-   feat: lex 0s 1s 0's 1's etc as words by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#775
-   refactor: nominal and determiner word types by [@&#8203;hippietrail](https://github.com/hippietrail) in Automattic/harper#731

#### New Contributors

-   [@&#8203;86xsk](https://github.com/86xsk) made their first contribution in Automattic/harper#767

**Full Changelog**: Automattic/harper@v0.23.0...v0.24.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment