Skip to content

Calendar: Remove 'taxonomy hierarchical' from editable fields for performance and usability #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryJones merged 1 commit into from
Dec 9, 2025
Merged

Calendar: Remove 'taxonomy hierarchical' from editable fields for performance and usability #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions modules/calendar/calendar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,12 +1102,6 @@ public function get_editable_html( $type, $value ) {
case 'taxonomy':
return '<input type="text" class="metadata-edit-' . esc_attr( $type ) . '" value="' . esc_attr( $value ) . '" />';
break;
case 'taxonomy hierarchical':
return wp_dropdown_categories( array(
'echo' => 0,
'hide_empty' => 0,
) );
break;
}
}

Expand Down Expand Up @@ -1181,27 +1175,28 @@ public function get_post_information_fields( $post ) {
} else {
$value = '';
}
//Used when editing editorial metadata and post meta
if ( is_taxonomy_hierarchical( $taxonomy->name ) ) {
$type = 'taxonomy hierarchical';
} else {
$type = 'taxonomy';
}

$information_fields[ $key ] = array(
'label' => $taxonomy->label,
'value' => $value,
'type' => $type,
);

if ( 'page' == $post->post_type ) {
$ed_cap = 'edit_page';
// Only allow non-hierarchical taxonomies to be edited in the calendar.
// Hierarchical taxonomies (like categories) cause performance issues and
// the single-select UI removes all but one category when saved.
if ( is_taxonomy_hierarchical( $taxonomy->name ) ) {
$information_fields[ $key ]['type'] = 'taxonomy hierarchical';
} else {
$ed_cap = 'edit_post';
}
$information_fields[ $key ]['type'] = 'taxonomy';

if ( current_user_can( $ed_cap, $post->ID ) ) {
$information_fields[ $key ]['editable'] = true;
if ( 'page' == $post->post_type ) {
$ed_cap = 'edit_page';
} else {
$ed_cap = 'edit_post';
}

if ( current_user_can( $ed_cap, $post->ID ) ) {
$information_fields[ $key ]['editable'] = true;
}
}
}

Expand Down Expand Up @@ -1698,7 +1693,6 @@ public function handle_ajax_update_metadata() {
} else {
switch ( $_POST['metadata_type'] ) {
case 'taxonomy':
case 'taxonomy hierarchical':
$response = wp_set_post_terms( $post->ID, $incoming_metadata_value, $metadata_term );
break;
default:
Expand Down
Loading