Calendar: Remove 'taxonomy hierarchical' from editable fields for performance and usability #757
Conversation
|
Hi @jerclarke, could you please rebase this PR onto |
…formance and usability Re: Automattic#756 Stop hierarchical taxonomies like categories from being edited inside the calendar, while continuing to allow non-hierarchical taxonomies (tags) to be edited. This avoids the horrific performance punishment on sites with many categories due to the full list of categories being inserted as a hidden field inside each and every post on the calendar. It also avoids using a single-select field to update categories, which removes all categories but the one chosen when saved. Users are better off editing the post directly if they need to change the categories. Co-authored-by: Jer Clarke <jer@simianuprising.com>
GaryJones
force-pushed
the
fix-calendar-taxonomy-editable
branch
from
153413c to
403892a
Compare
|
While there may be users who only have single, non-hierachical taxonomies (category) in use, I agree that data loss is too risky. I think there is an opportunity to use Ajax to pull in hierarchical lists as needed, instead of loading up all of the options for all of the posts on the calendar screen at once. We'd want a bigger modal overlay experience to potentially contain multiple checkbox-based hierarchical taxonomies. |
|
Thanks Gary! Sorry I didn't reply to the tickets last week, I was swamped with a work commitment and preparing a talk for a local WordPress meetup, of all things. I'll take a look at the others today! |
2 participants
Re: #756
Stop hierarchical taxonomies like categories from being edited inside the calendar, while continuing to allow non-hierarchical taxonomies (tags) to be edited.
This avoids the horrific performance punishment on sites with many categories due to the full list of categories being inserted as a hidden field inside each and every post on the calendar.
It also avoids using a single-select field to update categories, which removes all categories but the one chosen when saved. Users are better off editing the post directly if they need to change the categories, at least unless and until we can offer a proper multi-select category picker in the calendar (a terrible idea because of the performance issues mentioned above).