Skip to content

Remove redundant/unused JQuery methods #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ingeniumed merged 5 commits into from
Jun 27, 2024
Merged

Remove redundant/unused JQuery methods #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd85f5c
Port over the fixes from PRs 670 and 672
ingeniumed Jun 25, 2024
4bc3fc9
Merge branch 'add/vip-feature-flag' of github.com:Automattic/Edit-Flo…
ingeniumed Jun 25, 2024
9c5b607
Merge branch 'add/vip-feature-flag' of github.com:Automattic/Edit-Flo…
ingeniumed Jun 25, 2024
7eee981
Fix the merge conflicts due to the linting PR
ingeniumed Jun 27, 2024
7e1a6c7
Merge latest develop
ingeniumed Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
328 changes: 0 additions & 328 deletions common/js/jquery.quicksearch.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions edit_flow.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,8 +413,6 @@ public function register_scripts_and_styles() {
'selected' => esc_html__( 'Selected', 'edit-flow' ),
)
);

wp_register_script( 'jquery-quicksearch', EDIT_FLOW_URL . 'common/js/jquery.quicksearch.js', array( 'jquery' ), EDIT_FLOW_VERSION, true );
}
}

Expand Down
4 changes: 0 additions & 4 deletions modules/custom-status/lib/custom-status-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
return inlineEditCustomStatus.save( this );
}
} );

$( '#posts-filter input[type="submit"]' ).on( 'mousedown', function ( e ) {
t.revert();
} );
},

toggle( el ) {
Expand Down
2 changes: 1 addition & 1 deletion modules/editorial-metadata/editorial-metadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@ public function print_configure_view() {
<?php if ( ! isset( $_GET['action'] ) || ( isset( $_GET['action'] ) && 'edit-term' != $_GET['action'] ) ) : ?>
<div id="col-right">
<div class="col-wrap">
<form id="posts-filter" action="" method="post">
<form id="" action="" method="post">
<?php $wp_list_table->display(); ?>
<?php wp_nonce_field( 'editorial-metadata-sortable', 'editorial-metadata-sortable' ); ?>
</form>
Expand Down
4 changes: 0 additions & 4 deletions modules/editorial-metadata/lib/editorial-metadata-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
return inlineEditMetadataTerm.save( this );
}
} );

$( '#posts-filter input[type="submit"]' ).on( 'mousedown', function ( e ) {
t.revert();
} );
},

toggle( el ) {
Expand Down
3 changes: 1 addition & 2 deletions modules/notifications/notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ public function enqueue_admin_scripts() {

if ( $this->is_whitelisted_functional_view() ) {
wp_enqueue_script( 'jquery-listfilterizer' );
wp_enqueue_script( 'jquery-quicksearch' );
wp_enqueue_script( 'edit-flow-notifications-js', $this->module_url . 'lib/notifications.js', [ 'jquery', 'jquery-listfilterizer', 'jquery-quicksearch' ], EDIT_FLOW_VERSION, true );
wp_enqueue_script( 'edit-flow-notifications-js', $this->module_url . 'lib/notifications.js', [ 'jquery', 'jquery-listfilterizer' ], EDIT_FLOW_VERSION, true );
wp_localize_script(
'edit-flow-notifications-js',
'ef_notifications_localization',
Expand Down
4 changes: 0 additions & 4 deletions modules/user-groups/lib/user-groups-configure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
return inlineEditUsergroup.save( this );
}
} );

$( '#posts-filter input[type="submit"]' ).on( 'mousedown', function ( e ) {
t.revert();
} );
},

toggle( el ) {
Expand Down
Loading