Remove redundant/unused JQuery methods #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w into remove/redundant-jquery-methods
…w into remove/redundant-jquery-methods
This was referenced Jun 25, 2024
alecgeatches
approved these changes
Jun 27, 2024
Contributor
alecgeatches
left a comment
alecgeatches
left a comment
There was a problem hiding this comment.
Looks good! Tested the affected pages and confirmed nothing being removed here appears to be in use anymore. Thank you!
This was
linked to
issues
Jun 27, 2024
GaryJones
added
the
type: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is essentially an amalgamation of #670 and #672. So when reviewing the files that have been linted entirely, you can use the fixes from those two PRs as reference.
Note: when testing this, make sure you activate your network tab's disable cache so you don't get the old JS code served.
The testing instructions in both those PRs are pretty comprehensive so I just used those.
Fixes #661 and #664