Fix issues with single-room mode and guest login #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
force-pushed
the
single-room-fixes
branch
from
2ed7a67 to
2430728
Compare
psrpinto
force-pushed
the
single-room-fixes
branch
from
246a877 to
1ea96eb
Compare
Without it login does not function correctly.
…e and there are no sessions
|
Partially reviewed with @ashfame on a call, merging so we can ship the fixes for guest login. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
This PR fixes several issues with single-room mode and guest login.
Previously we were disabling hydrogen's feature of restoring the last URL, but this breaks hydrogen in subtle ways. So we're no longer doing that globally, instead we only do it for the cases where it makes sense (login and "empty" session picker).
Additionally, we were re-implementing functionality that is already in hydrogen, related to showing the unknown room and checking if it's world-readable. In chatrix we don't need to do this, we just need to login as guest when appropriate, and send the user to the room.
The code that manages which screen is shown under which conditions is hard to understand IMHO (hydrogen is missing a proper "router"), so I refactored it a bit and added a bunch of comments.
I tested this in all the ways I could think of and did not find any issues. However, there are unrelated issues that can look like it's an issue with this PR (#224 and #225) so take that in mind if you do testing on your side.
TODO