Skip to content

Conversation

@psrpinto
Copy link
Member

@psrpinto psrpinto commented Nov 22, 2022

Fixes #121

Screen recording

Screen.Recording.2022-11-23.at.16.30.00.mov

Next steps

  1. Set block border and border-radius #136
  2. Allow specifying the height unit #137

@psrpinto psrpinto self-assigned this Nov 22, 2022
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a padding-bottom to avoid the cut-off handle?

missing-padding-bottom

@psrpinto
Copy link
Member Author

psrpinto commented Nov 23, 2022

The cut-off handle is due to b3bba5f, which I'm now convinced was not the correct fix for the problem, as it creates other problems. I have some ideas on how to fix the rounded corners problem in another way, which I'm exploring now.

Adding padding fixes the cut-off handle but also adds padding, so I'd rather find a solution that addresses the root problem, which is b3bba5f.

@psrpinto
Copy link
Member Author

@akirk I will address the issue with the cut-off handle in #136, if that works for you. I've also updated the PR description with a video that shows the final result.

@psrpinto psrpinto marked this pull request as ready for review November 23, 2022 16:49
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do that in #136.

@psrpinto psrpinto merged commit e4e2a70 into main Nov 24, 2022
@psrpinto psrpinto deleted the configure-height branch November 24, 2022 13:41
@psrpinto psrpinto mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block height should not be hardcoded

3 participants