-
Notifications
You must be signed in to change notification settings - Fork 60
Add tooltip text for Configure Assets panel #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltip text for Configure Assets panel #1125
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, can you try and run the auto formatter so the workflow passes? Just looking for eslint to pass.
Just ran it through the formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the branch you are requesting the PR to be merged into to be Autodesk:dev (since we don't merge directly into prod)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the extra package-lock.json here
fission/src/ui/panels/configuring/assembly-config/ConfigurePanel.tsx
Outdated
Show resolved
Hide resolved
…el.tsx Co-authored-by: Dhruv Arora <a_dhruv@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool looks good 🚀
Description
Adds helpful tooltips to the Robots and Fields sections of Configure Assets panel for a more intuitive UI.